Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2644733002:
[IR3] Introduce ImageResource::updateImage() (Closed)
DescriptionIntroduce ImageResource::updateImage()
This CL centralizes ImageResourceContent::updateImage() calls into a single
point of ImageResource::updateImage() to help further refactoring.
No behavior changes.
BUG=667641
Review-Url: https://codereview.chromium.org/2644733002
Cr-Commit-Position: refs/heads/master@{#445520}
Committed: https://chromium.googlesource.com/chromium/src/+/30e0ef53363917a324acf0b89f62f64223d06f3f
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Comment #Patch Set 4 : Rebase #Patch Set 5 : Rebase #
Messages
Total messages: 26 (22 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Introduce ImageResource::updateImage() BUG=667641 ========== to ========== Introduce ImageResource::updateImage() This CL centralizes ImageResourceContent::updateImage() calls into a single point of ImageResource::updateImage() to help further refactoring. No behavior changes. BUG=667641 ==========
hiroshige@chromium.org changed reviewers: + japhet@chromium.org, yhirano@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL.
lgtm
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org Link to the patchset: https://codereview.chromium.org/2644733002/#ps80001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485197112241700,
"parent_rev": "5f4f2ea179de07bc7f4f141c234ed8888c1b57f2", "commit_rev":
"30e0ef53363917a324acf0b89f62f64223d06f3f"}
Message was sent while issue was closed.
Description was changed from ========== Introduce ImageResource::updateImage() This CL centralizes ImageResourceContent::updateImage() calls into a single point of ImageResource::updateImage() to help further refactoring. No behavior changes. BUG=667641 ========== to ========== Introduce ImageResource::updateImage() This CL centralizes ImageResourceContent::updateImage() calls into a single point of ImageResource::updateImage() to help further refactoring. No behavior changes. BUG=667641 Review-Url: https://codereview.chromium.org/2644733002 Cr-Commit-Position: refs/heads/master@{#445520} Committed: https://chromium.googlesource.com/chromium/src/+/30e0ef53363917a324acf0b89f62... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/30e0ef53363917a324acf0b89f62... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
