Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2644723003: Remove lock from TaskQueueImpl::RunsTasksOnCurrentThread (Closed)

Created:
3 years, 11 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 11 months ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove lock from TaskQueueImpl::RunsTasksOnCurrentThread This lock seems superfluous. Originally part of https://codereview.chromium.org/2546423002/ BUG=578176 Review-Url: https://codereview.chromium.org/2644723003 Cr-Commit-Position: refs/heads/master@{#444708} Committed: https://chromium.googlesource.com/chromium/src/+/fa306e3b84935b7f953e921ce3f3f96afc064ac3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
alex clarke (OOO till 29th)
PTAL
3 years, 11 months ago (2017-01-19 09:34:27 UTC) #4
Sami
lgtm
3 years, 11 months ago (2017-01-19 12:01:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644723003/1
3 years, 11 months ago (2017-01-19 12:06:20 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 12:10:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa306e3b84935b7f953e921ce3f3...

Powered by Google App Engine
This is Rietveld 408576698