cros: Use runtime stylus detection for ash palette.

cros: Use runtime stylus detection for ash palette.

The same cros image can be used on devices both with and without stylus support. This means we have to use runtime detection for enabling the palette, as we cannot differentiate in the overlay as we do now (USE="stylus").

BUG=679451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2644713002
Cr-Commit-Position: refs/heads/master@{#448858}
Committed: https://chromium.googlesource.com/chromium/src/+/d08c50b08dfba28fea35212d604fa4619b663724

[jdufault, 2017-01-18 20:04:35]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 20:05:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-01-18 20:25:36]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 20:26:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:14:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2017-01-18 23:20:50]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:21:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 00:30:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jdufault, 2017-01-20 21:58:45]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 21:59:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-01-20 22:00:30]

Patchset #1 (id:1) has been deleted

[jdufault, 2017-01-20 22:00:39]

Patchset #1 (id:20001) has been deleted

[jdufault, 2017-01-20 22:00:47]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-20 22:49:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 22:49:21]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-20 22:58:15]

Description was changed from

==========
cros: Use runtime stylus detection for ash palette.

BUG=679451
==========

to

==========
cros: Use runtime stylus detection for ash palette.

BUG=679451
==========

[jdufault, 2017-01-20 22:58:15]

jdufault@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jdufault, 2017-01-20 23:01:41]

Description was changed from

==========
cros: Use runtime stylus detection for ash palette.

BUG=679451
==========

to

==========
cros: Use runtime stylus detection for ash palette.

The same cros image can be used on devices both with and without stylus support.
This means we have to use runtime detection for enabling the palette, as we
cannot differentiate in the overlay as we do now (USE="stylus").

BUG=679451
==========

[jdufault, 2017-01-20 23:02:15]

jdufault@chromium.org changed reviewers:
+ jamescook@chromium.org

[jdufault, 2017-01-20 23:02:30]

stevenjb@, jamescook@, PTAL. Thanks!

[stevenjb, 2017-01-21 00:23:50]

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:422: if (delegate) {
if (!delegate) return;

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.h (right):

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.h:85: void
OnStylusStateChanged(ui::StylusState stylus_state) override;
It's a bit odd to have some overrides private and others public, but there seems
to already be precedent for that here. *shrug*. My preference would be to put
these with the public overrides, since the methods are effectively public.

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_utils.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_utils.cc:23:
switches::kAshEnablePalette)) {
This switch name is now a bit unfortunate, it seems like it should be something
like kAshForceEnablePalette. (I.e. it sounds like without the switch this would
always return false).

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc:64:
localized_strings->SetBoolean("showStylusSettings", ash::HasStylusInput());
Do we need an observer now to set this if it changes?

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_ui.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_ui.cc:153:
html_source->AddBoolean("stylusAllowed", ash::HasStylusInput());
Observer in case it changes?

[James Cook, 2017-01-23 16:58:48]

I'll let you sort things out with Steven first - ping me when you want me to
look.

[jdufault, 2017-01-23 23:02:54]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 23:04:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 00:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 00:05:24]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-25 00:53:15]

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.cc:422: if (delegate) {
On 2017/01/21 00:23:50, stevenjb wrote:
> if (!delegate) return;

Done.

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.h (right):

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.h:85: void
OnStylusStateChanged(ui::StylusState stylus_state) override;
On 2017/01/21 00:23:50, stevenjb wrote:
> It's a bit odd to have some overrides private and others public, but there
seems
> to already be precedent for that here. *shrug*. My preference would be to put
> these with the public overrides, since the methods are effectively public.
> 

I think the rationale for making these private is that they are technically part
of the API, but not meant to be called directly and are an implementation
detail. Using that same line of thinking, most of the public overrides above
should actually be private as well.

wdyt?

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_utils.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_utils.cc:23:
switches::kAshEnablePalette)) {
On 2017/01/21 00:23:50, stevenjb wrote:
> This switch name is now a bit unfortunate, it seems like it should be
something
> like kAshForceEnablePalette. (I.e. it sounds like without the switch this
would
> always return false).
> 

I've renamed the switch.

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc:64:
localized_strings->SetBoolean("showStylusSettings", ash::HasStylusInput());
On 2017/01/21 00:23:50, stevenjb wrote:
> Do we need an observer now to set this if it changes?

Technically, yes, but I think the only time this would be a problem is if
settings opens and loads immediately on login after the Chrome binary has
restarted (either from a crash or the user has custom flags set).

One issue with dynamically changing this value is that page initialization
currently does not support showing a section dynamically. I think this could be
fixed though without too much hassle - it'll probably involve adding a new
callback from C++ -> JS though.

I can fix these problems, if you think addressing this edge-case is worthwhile.

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_ui.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_ui.cc:153:
html_source->AddBoolean("stylusAllowed", ash::HasStylusInput());
On 2017/01/21 00:23:50, stevenjb wrote:
> Observer in case it changes?

See above comment

[stevenjb, 2017-01-25 01:12:13]

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
File ash/common/system/chromeos/palette/palette_tray.h (right):

https://codereview.chromium.org/2644713002/diff/60001/ash/common/system/chrom...
ash/common/system/chromeos/palette/palette_tray.h:85: void
OnStylusStateChanged(ui::StylusState stylus_state) override;
On 2017/01/25 00:53:15, jdufault wrote:
> On 2017/01/21 00:23:50, stevenjb wrote:
> > It's a bit odd to have some overrides private and others public, but there
> seems
> > to already be precedent for that here. *shrug*. My preference would be to
put
> > these with the public overrides, since the methods are effectively public.
> > 
> 
> I think the rationale for making these private is that they are technically
part
> of the API, but not meant to be called directly and are an implementation
> detail. Using that same line of thinking, most of the public overrides above
> should actually be private as well.
> 
> wdyt?

Personally I prefer to keep public/private consistent with the parent class
declaration (i.e. generally public), since methods declared public in the parent
class are in fact public. Mostly we should be consistent.

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc:64:
localized_strings->SetBoolean("showStylusSettings", ash::HasStylusInput());
On 2017/01/25 00:53:15, jdufault wrote:
> On 2017/01/21 00:23:50, stevenjb wrote:
> > Do we need an observer now to set this if it changes?
> 
> Technically, yes, but I think the only time this would be a problem is if
> settings opens and loads immediately on login after the Chrome binary has
> restarted (either from a crash or the user has custom flags set).
> 
> One issue with dynamically changing this value is that page initialization
> currently does not support showing a section dynamically. I think this could
be
> fixed though without too much hassle - it'll probably involve adding a new
> callback from C++ -> JS though.
> 
> I can fix these problems, if you think addressing this edge-case is
worthwhile.

Custom flags are not too uncommon, so this really depends on how
ash::HasStylusInput() is implemented (I think I saw but I don't remember and
can't find it just now). If there is a reasonable chance that loading settings
right away might have an incorrect result, we should add the observer and a C++
-> JS method. If it is only theoretical we can get away with just adding a
comment.

[jdufault, 2017-02-02 22:00:53]

Description was changed from

==========
cros: Use runtime stylus detection for ash palette.

The same cros image can be used on devices both with and without stylus support.
This means we have to use runtime detection for enabling the palette, as we
cannot differentiate in the overlay as we do now (USE="stylus").

BUG=679451
==========

to

==========
cros: Use runtime stylus detection for ash palette.

The same cros image can be used on devices both with and without stylus support.
This means we have to use runtime detection for enabling the palette, as we
cannot differentiate in the overlay as we do now (USE="stylus").

BUG=679451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2017-02-02 22:00:56]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 22:01:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:40:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:40:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2017-02-03 02:27:56]

Patchset #5 (id:140001) has been deleted

[jdufault, 2017-02-03 02:29:28]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 02:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 04:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 04:05:51]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-02-03 20:30:19]

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc (right):

https://codereview.chromium.org/2644713002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/options_stylus_handler.cc:64:
localized_strings->SetBoolean("showStylusSettings", ash::HasStylusInput());
On 2017/01/25 01:12:13, stevenjb wrote:
> On 2017/01/25 00:53:15, jdufault wrote:
> > On 2017/01/21 00:23:50, stevenjb wrote:
> > > Do we need an observer now to set this if it changes?
> > 
> > Technically, yes, but I think the only time this would be a problem is if
> > settings opens and loads immediately on login after the Chrome binary has
> > restarted (either from a crash or the user has custom flags set).
> > 
> > One issue with dynamically changing this value is that page initialization
> > currently does not support showing a section dynamically. I think this could
> be
> > fixed though without too much hassle - it'll probably involve adding a new
> > callback from C++ -> JS though.
> > 
> > I can fix these problems, if you think addressing this edge-case is
> worthwhile.
> 
> Custom flags are not too uncommon, so this really depends on how
> ash::HasStylusInput() is implemented (I think I saw but I don't remember and
> can't find it just now). If there is a reasonable chance that loading settings
> right away might have an incorrect result, we should add the observer and a
C++
> -> JS method. If it is only theoretical we can get away with just adding a
> comment.

If Chrome browser process crashed and immediately reloaded one of the settings
pages on startup, the stylus settings failed to display. I've implemented some
observers that in options/settings that fix this case.

[stevenjb, 2017-02-03 23:11:26]

lgtm

https://codereview.chromium.org/2644713002/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/settings/device_page/device_page.js (right):

https://codereview.chromium.org/2644713002/diff/160001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/device_page.js:35: hasStylus_:
Boolean,
This should actually initialize to 'false', otherwise it will be undefined which
can have unexpected behavior (see https://github.com/Polymer/polymer/issues/2447
if you are curious). I believe that currently this will behave as expected, but
better I think to explicitly hide the section initially.

[jdufault, 2017-02-06 21:43:31]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 21:44:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-02-06 21:44:42]

https://codereview.chromium.org/2644713002/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/settings/device_page/device_page.js (right):

https://codereview.chromium.org/2644713002/diff/160001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/device_page.js:35: hasStylus_:
Boolean,
On 2017/02/03 23:11:26, stevenjb wrote:
> This should actually initialize to 'false', otherwise it will be undefined
which
> can have unexpected behavior (see
https://github.com/Polymer/polymer/issues/2447
> if you are curious). I believe that currently this will behave as expected,
but
> better I think to explicitly hide the section initially.

Done; I was following the pattern for hasMouse_ and hasTouchpad_ so I've updated
those so they also explicitly initialize to false.

[commit-bot: I haz the power, 2017-02-06 22:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 22:59:35]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-02-06 23:06:39]

ash LGTM with nits

https://codereview.chromium.org/2644713002/diff/200001/ash/common/ash_switche...
File ash/common/ash_switches.cc (right):

https://codereview.chromium.org/2644713002/diff/200001/ash/common/ash_switche...
ash/common/ash_switches.cc:55: const char kAshForceEnablePalette[] =
"ash-force-enable-palette";
nit: alphabetize

https://codereview.chromium.org/2644713002/diff/200001/ash/common/ash_switches.h
File ash/common/ash_switches.h (right):

https://codereview.chromium.org/2644713002/diff/200001/ash/common/ash_switche...
ash/common/ash_switches.h:28: ASH_EXPORT extern const char
kAshForceEnablePalette[];
nit: alphabetize

https://codereview.chromium.org/2644713002/diff/200001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2644713002/diff/200001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:411: if (!delegate)
Maybe add a note about when delegate can be null?

https://codereview.chromium.org/2644713002/diff/200001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_utils.h (right):

https://codereview.chromium.org/2644713002/diff/200001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_utils.h:19: ASH_EXPORT bool
HasStylusInput();
nit: The functions in this class should be in either namespace
ash::palette_utils:: or a static-only utility class.

Raw functions in large namespaces like ash:: make my head hurt. :-)

[jdufault, 2017-02-07 20:10:44]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 20:11:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 22:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 22:23:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2017-02-08 00:08:31]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 00:09:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 01:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:28:27]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-02-08 02:06:21]

https://codereview.chromium.org/2644713002/diff/200001/ash/common/ash_switche...
File ash/common/ash_switches.cc (right):

https://codereview.chromium.org/2644713002/diff/200001/ash/common/ash_switche...
ash/common/ash_switches.cc:55: const char kAshForceEnablePalette[] =
"ash-force-enable-palette";
On 2017/02/06 23:06:39, James Cook wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/2644713002/diff/200001/ash/common/ash_switches.h
File ash/common/ash_switches.h (right):

https://codereview.chromium.org/2644713002/diff/200001/ash/common/ash_switche...
ash/common/ash_switches.h:28: ASH_EXPORT extern const char
kAshForceEnablePalette[];
On 2017/02/06 23:06:39, James Cook wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/2644713002/diff/200001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_tray.cc (right):

https://codereview.chromium.org/2644713002/diff/200001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_tray.cc:411: if (!delegate)
On 2017/02/06 23:06:39, James Cook wrote:
> Maybe add a note about when delegate can be null?

Done.

https://codereview.chromium.org/2644713002/diff/200001/ash/common/system/chro...
File ash/common/system/chromeos/palette/palette_utils.h (right):

https://codereview.chromium.org/2644713002/diff/200001/ash/common/system/chro...
ash/common/system/chromeos/palette/palette_utils.h:19: ASH_EXPORT bool
HasStylusInput();
On 2017/02/06 23:06:39, James Cook wrote:
> nit: The functions in this class should be in either namespace
> ash::palette_utils:: or a static-only utility class.
> 
> Raw functions in large namespaces like ash:: make my head hurt. :-)

Done.

[jdufault, 2017-02-08 02:06:27]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-02-08 02:06:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2644713002/#ps260001
(title: "Fix test")

[commit-bot: I haz the power, 2017-02-08 02:07:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 02:14:28]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1486519587550670,
"parent_rev": "dc9da748141ad5f270ad75435a7ae63ac9227e64", "commit_rev":
"d08c50b08dfba28fea35212d604fa4619b663724"}

[commit-bot: I haz the power, 2017-02-08 02:14:58]

Description was changed from

==========
cros: Use runtime stylus detection for ash palette.

The same cros image can be used on devices both with and without stylus support.
This means we have to use runtime detection for enabling the palette, as we
cannot differentiate in the overlay as we do now (USE="stylus").

BUG=679451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Use runtime stylus detection for ash palette.

The same cros image can be used on devices both with and without stylus support.
This means we have to use runtime detection for enabling the palette, as we
cannot differentiate in the overlay as we do now (USE="stylus").

BUG=679451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2644713002
Cr-Commit-Position: refs/heads/master@{#448858}
Committed:
https://chromium.googlesource.com/chromium/src/+/d08c50b08dfba28fea35212d604f...
==========

[commit-bot: I haz the power, 2017-02-08 02:15:01]

Committed patchset #10 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/d08c50b08dfba28fea35212d604f...