Fix memory management of VoiceSearchBarView.

ios/chrome/browser/ui/browser_view_controller.mm

Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 2cc3d7b1a3e1efc3f37c274ad7b10aeb8ddccbf7..d77278db9002e85bf44434a0ae1691b595a7643b 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -435,8 +435,7 @@ @interface BrowserViewController ()<AppRatingPromptDelegate,
   std::unique_ptr<InfoBarContainerDelegateIOS> _infoBarContainerDelegate;
 
   // Voice search bar at the bottom of the view overlayed on |_contentArea|
-  // when displaying voice search results. Implementation is not complete.
-  // See b/7998125.
+  // when displaying voice search results.
   base::scoped_nsprotocol<UIView<VoiceSearchBar>*> _voiceSearchBar;
 
   // The image fetcher used to save images and perform image-based searches.
@@ -2290,9 +2289,9 @@ - (void)ensureVoiceSearchBarCreated {
   CGFloat width = CGRectGetWidth([[self view] bounds]);
   CGFloat y = CGRectGetHeight([[self view] bounds]) - kVoiceSearchBarHeight;
   CGRect frame = CGRectMake(0.0, y, width, kVoiceSearchBarHeight);
-  _voiceSearchBar.reset(ios::GetChromeBrowserProvider()
-                            ->GetVoiceSearchProvider()
-                            ->CreateVoiceSearchBar(frame));
+  _voiceSearchBar.reset([ios::GetChromeBrowserProvider()
+                             ->GetVoiceSearchProvider()
+                             ->BuildVoiceSearchBar(frame) retain]);

[rohitrao (ping after 24h), 2017/01/20 14:00:26]

We can't change callers to the new API until the downstream implementation is in
place, can we?

[kkhorimoto, 2017/01/24 01:36:18]

Moved it to the third of 3-way patch.

   [_voiceSearchBar setVoiceSearchBarDelegate:self];
   [_voiceSearchBar setHidden:YES];
   [_voiceSearchBar setAutoresizingMask:UIViewAutoresizingFlexibleTopMargin |