Fix memory management of VoiceSearchBarView.

ios/chrome/browser/ui/browser_view_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 
 #import <AssetsLibrary/AssetsLibrary.h>
 #import <MobileCoreServices/MobileCoreServices.h>
 #import <PassKit/PassKit.h>
 #import <Photos/Photos.h>
@@ skipping 417 matching lines @@
 
   // A single infobar container handles all infobars in all tabs. It keeps
   // track of infobars for current tab (accessed via infobar helper of
   // the current tab).
   std::unique_ptr<InfoBarContainerIOS> _infoBarContainer;
 
   // Bridge class to deliver container change notifications to BVC.
   std::unique_ptr<InfoBarContainerDelegateIOS> _infoBarContainerDelegate;
 
   // Voice search bar at the bottom of the view overlayed on |_contentArea|
-  // when displaying voice search results. Implementation is not complete.
-  // See b/7998125.
+  // when displaying voice search results.
   base::scoped_nsprotocol<UIView<VoiceSearchBar>*> _voiceSearchBar;
 
   // The image fetcher used to save images and perform image-based searches.
   std::unique_ptr<web::ImageDataFetcher> _imageFetcher;
 
   // Card side swipe view.
   base::scoped_nsobject<CardSideSwipeView> _sideSwipeView;
 
   // Used to cache value of |hasModeToggleSwitch| if set before the tab strip
   // controller has been created.
@@ skipping 1833 matching lines @@
   }
 }
 
 - (void)ensureVoiceSearchBarCreated {
   if (_voiceSearchBar)
     return;
 
   CGFloat width = CGRectGetWidth([[self view] bounds]);
   CGFloat y = CGRectGetHeight([[self view] bounds]) - kVoiceSearchBarHeight;
   CGRect frame = CGRectMake(0.0, y, width, kVoiceSearchBarHeight);
-  _voiceSearchBar.reset(ios::GetChromeBrowserProvider()
-                            ->GetVoiceSearchProvider()
-                            ->CreateVoiceSearchBar(frame));
+  _voiceSearchBar.reset([ios::GetChromeBrowserProvider()
+                             ->GetVoiceSearchProvider()
+                             ->BuildVoiceSearchBar(frame) retain]);

[rohitrao (ping after 24h), 2017/01/20 14:00:26]

We can't change callers to the new API until the downstream implementation is in
place, can we?

[kkhorimoto, 2017/01/24 01:36:18]

Moved it to the third of 3-way patch.

   [_voiceSearchBar setVoiceSearchBarDelegate:self];
   [_voiceSearchBar setHidden:YES];
   [_voiceSearchBar setAutoresizingMask:UIViewAutoresizingFlexibleTopMargin |
                                        UIViewAutoresizingFlexibleWidth];
   [self.view insertSubview:_voiceSearchBar
               belowSubview:_infoBarContainer->view()];
 }
 
 - (void)updateVoiceSearchBarVisibilityAnimated:(BOOL)animated {
   // Voice search bar exists and is shown/hidden.
@@ skipping 2828 matching lines @@
 
 - (UIView*)voiceSearchButton {
   return _voiceSearchButton;
 }
 
 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
   return [self currentLogoAnimationControllerOwner];
 }
 
 @end