DevTools: Show CSS variables in the inherited properties cascade

DevTools: Show CSS variables in the inherited properties cascade

BUG=680693
Review-Url: https://codereview.chromium.org/2644703002
Cr-Commit-Position: refs/heads/master@{#444929}
Committed: https://chromium.googlesource.com/chromium/src/+/f2a640e932be7a9765472c6d6e8f90f9b2a02970

[einbinder, 2017-01-18 19:55:18]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2017-01-18 19:55:19]

ptal

[einbinder, 2017-01-18 19:55:23]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 19:55:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:46:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:46:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2017-01-18 21:58:21]

We need a test.

[einbinder, 2017-01-19 20:14:30]

The current CSS variables test should provide adequate coverage with the new
expected file. Covers both the cascade and computed styles.

[einbinder, 2017-01-19 20:14:46]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 20:15:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 22:30:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2017-01-19 23:17:25]

lgtm

[einbinder, 2017-01-20 00:04:08]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-01-20 00:05:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:41:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484870648722930,
"parent_rev": "c0a1a6a9845473c88802078e8bb4fd02647d7620", "commit_rev":
"f2a640e932be7a9765472c6d6e8f90f9b2a02970"}

[commit-bot: I haz the power, 2017-01-20 01:41:34]

Description was changed from

==========
DevTools: Show CSS variables in the inherited properties cascade

BUG=680693
==========

to

==========
DevTools: Show CSS variables in the inherited properties cascade

BUG=680693

Review-Url: https://codereview.chromium.org/2644703002
Cr-Commit-Position: refs/heads/master@{#444929}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2a640e932be7a9765472c6d6e8f...
==========

[commit-bot: I haz the power, 2017-01-20 01:41:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2a640e932be7a9765472c6d6e8f...

[lushnikov, 2017-01-23 05:13:20]

lushnikov@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2017-01-23 05:13:21]

nice patch!

https://codereview.chromium.org/2644703002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
(right):

https://codereview.chromium.org/2644703002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js:217:
if (a.startsWith('--') ^ b.startsWith('--'))
fyi: "^" is a bit-xor, not a logical xor, so it might yield surprising results
in certain cases. I'd rather use:

a.startsWith('--') !== b.startsWith('--')