Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2644693003: SUMMARY element: click() for invisible SUMMARY should toggle DETAILS element. (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SUMMARY element: click() for invisible SUMMARY should toggle DETAILS element. We had unreasonable layoutObject() existence check for DOMActivate event handling. It's not defined by the stadard. BUG=681711 Review-Url: https://codereview.chromium.org/2644693003 Cr-Commit-Position: refs/heads/master@{#444679} Committed: https://chromium.googlesource.com/chromium/src/+/c162ebcbfa71bfbdd8e3fdba2137c382f752b4b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/html/summary-invisible-click.html View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
yosin@, would you review this please?
3 years, 11 months ago (2017-01-19 07:09:31 UTC) #4
yosin_UTC9
lgtm
3 years, 11 months ago (2017-01-19 08:12:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644693003/1
3 years, 11 months ago (2017-01-19 08:12:40 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 08:17:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c162ebcbfa71bfbdd8e3fdba2137...

Powered by Google App Engine
This is Rietveld 408576698