Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html

Issue 2644653003: Make OffscreenCanvas animation in sync with its placeholder canvas's parent frame rate (Closed)
Patch Set: rebase again Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html
diff --git a/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html b/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html
index 0668fff99a5621ce91c44960cbaec74e0aaa760a..02f3a123349302090c3c2026608a2e0a11a9730a 100644
--- a/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html
+++ b/content/test/data/gpu/pixel_offscreenCanvas_2d_commit_worker.html
@@ -22,16 +22,28 @@ var g_animationFrameNumber = 0;
self.onmessage = function(e) {
var transferredCanvas = e.data;
g_offscreen2d = transferredCanvas.getContext("2d");
+ g_offscreen2d.fillStyle = "red";
+ g_offscreen2d.fillRect(0, 0, 200, 200);
drawLoop();
}
function drawLoop()
{
- if (g_animationFrameNumber < 3) {
- g_offscreen2d.fillStyle = "red";
- g_offscreen2d.fillRect(0, 0, 200, 200);
+ if (g_animationFrameNumber < 10) {
g_animationFrameNumber++;
- g_offscreen2d.commit().then(drawLoop);
+ // Purposely intersperse overdraw and non-overdraw commit cases to see
+ // if OffscreenCanvas commit() handles both cases well.
+ if (0 == g_animationFrameNumber % 2) {
+ // When promise is used, the next drawLoop() is called after the first
+ // frame is resolved; therefore there is no overdraw in this case.
+ g_offscreen2d.commit().then(drawLoop);
+ } else {
+ // When the next drawLoop() is invoked regardless the promise resolve
+ // status of the previous commit(), the frame committed in the next
+ // drawLoop() is very likely to be overdrawn.
+ g_offscreen2d.commit();
+ drawLoop();
+ }
} else {
g_offscreen2d.fillStyle = "red";
g_offscreen2d.fillRect(0, 0, 100, 100);

Powered by Google App Engine
This is Rietveld 408576698