Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2644643005: [Sync] Add skym to sync OWNERS. (Closed)

Created:
3 years, 11 months ago by skym
Modified:
3 years, 11 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Add skym to sync OWNERS. A few other changes that were made while in here: 1. Updated all OWNERS files to reference components/sync/OWNERS so updates in the future can happen in exactly one place. 2. Removed per-file for sync_android.gypi. This file doesn't exist anymore after moving to gn. 3. Removed removed per-file for sync_policy_handler*. This rule was previously broken due to componentization file moves. It doesn't look like these (smallish) files haven't seen significant changes since 2013, and I don't think having special ownership rules for them is adding significant value. So in favor of simplicity I've removed them. BUG= Review-Url: https://codereview.chromium.org/2644643005 Cr-Commit-Position: refs/heads/master@{#445099} Committed: https://chromium.googlesource.com/chromium/src/+/aedecb001ada18b1ad781f6ebddeabccaf9a62b7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding files I missed, and added references. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -31 lines) Patch
M chrome/browser/sync/OWNERS View 1 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/sync/OWNERS View 1 1 chunk +2 lines, -4 lines 0 comments Download
M components/browser_sync/OWNERS View 1 1 chunk +1 line, -4 lines 0 comments Download
M components/sync/OWNERS View 1 1 chunk +1 line, -3 lines 0 comments Download
M components/sync_bookmarks/OWNERS View 1 1 chunk +1 line, -4 lines 0 comments Download
M components/sync_sessions/OWNERS View 1 1 chunk +1 line, -4 lines 0 comments Download
M ios/chrome/browser/sync/OWNERS View 1 1 chunk +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/OWNERS View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
skym
PTAL
3 years, 11 months ago (2017-01-19 15:24:56 UTC) #5
maxbogue
You missed: chrome/browser/ui/sync/OWNERS ios/chrome/browser/sync/OWNERS ios/chrome/browser/ui/webui/sync_internals/OWNERS Also we should really change all of these to just ...
3 years, 11 months ago (2017-01-19 17:01:00 UTC) #8
maxbogue
https://codereview.chromium.org/2644643005/diff/1/components/sync/OWNERS File components/sync/OWNERS (right): https://codereview.chromium.org/2644643005/diff/1/components/sync/OWNERS#newcode7 components/sync/OWNERS:7: per-file sync_android.gypi=nyquist@chromium.org Oh hey you can also remove these ...
3 years, 11 months ago (2017-01-19 17:04:08 UTC) #9
maxbogue
3 years, 11 months ago (2017-01-19 17:04:09 UTC) #10
skym
Updated for Max's comments. https://codereview.chromium.org/2644643005/diff/1/components/sync/OWNERS File components/sync/OWNERS (right): https://codereview.chromium.org/2644643005/diff/1/components/sync/OWNERS#newcode7 components/sync/OWNERS:7: per-file sync_android.gypi=nyquist@chromium.org On 2017/01/19 17:04:08, ...
3 years, 11 months ago (2017-01-19 18:19:04 UTC) #12
Nicolas Zea
Huh, I didn't know you could refer to another file in OWNERS. LGTM
3 years, 11 months ago (2017-01-20 18:16:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644643005/20001
3 years, 11 months ago (2017-01-20 18:25:21 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 18:35:52 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aedecb001ada18b1ad781f6ebdde...

Powered by Google App Engine
This is Rietveld 408576698