Issue 264463002: GN build improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264463002: GN build improvements. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org, tdresser+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GN build improvements. Fixes a TODO about private symbols on GCC. Moves many third party BUILD.gn files from the secondary tree to the main one. Fixes the dependencies on Linux so "gn check" passes again. BUG=367595 R=scottmg@chromium.org Previous review: https://codereview.chromium.org/256153003/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267233

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -501 lines)			Patch
M	components/translate/BUILD.gn	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	crypto/BUILD.gn	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	net/BUILD.gn	View	3 chunks	+35 lines, -27 lines	0 comments	Download
M	net/third_party/nss/ssl/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	third_party/expat/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	third_party/libevent/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/libxml/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/mach_override/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/snappy/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/wtl/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	third_party/zlib/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	tools/gn/secondary/third_party/expat/BUILD.gn	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	tools/gn/secondary/third_party/libevent/BUILD.gn	View	1 chunk	+0 lines, -45 lines	0 comments	Download
D	tools/gn/secondary/third_party/libxml/BUILD.gn	View	1 chunk	+0 lines, -190 lines	0 comments	Download
D	tools/gn/secondary/third_party/mach_override/BUILD.gn	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	tools/gn/secondary/third_party/snappy/BUILD.gn	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	tools/gn/secondary/third_party/wtl/BUILD.gn	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	tools/gn/secondary/third_party/zlib/BUILD.gn	View	1 chunk	+0 lines, -102 lines	0 comments	Download
M	ui/events/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gfx/BUILD.gn	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r267233.

Expand Messages | Collapse Messages