Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/gn/secondary/third_party/snappy/BUILD.gn

Issue 264463002: GN build improvements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/secondary/third_party/mach_override/BUILD.gn ('k') | tools/gn/secondary/third_party/wtl/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/third_party/snappy/BUILD.gn
diff --git a/tools/gn/secondary/third_party/snappy/BUILD.gn b/tools/gn/secondary/third_party/snappy/BUILD.gn
deleted file mode 100644
index 705cb8aa2b8d7ffea3714220a5cfc7f6b04f048e..0000000000000000000000000000000000000000
--- a/tools/gn/secondary/third_party/snappy/BUILD.gn
+++ /dev/null
@@ -1,46 +0,0 @@
-# Copyright (c) 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-config("snappy_config") {
- include_dirs = [
- "src",
- ]
-
- # These OS-specific generated headers were made by running the configure
- # script offline.
- if (is_win) {
- include_dirs += [ "win32" ]
- } else if (is_mac) {
- include_dirs += [ "mac" ]
- } else {
- include_dirs += [ "linux" ]
- }
-}
-
-static_library("snappy") {
- sources = [
- "src/snappy-internal.h",
- "src/snappy-sinksource.cc",
- "src/snappy-sinksource.h",
- "src/snappy-stubs-internal.cc",
- "src/snappy-stubs-internal.h",
- "src/snappy.cc",
- "src/snappy.h",
- ]
-
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
- direct_dependent_configs = [ ":snappy_config" ]
-
- if (is_clang) {
- # snappy-stubs-internal.h unapologetically has: using namespace std
- # https://code.google.com/p/snappy/issues/detail?id=70
- configs -= [ "//build/config/clang:extra_warnings" ]
- }
-
- if (is_win) {
- # https://code.google.com/p/snappy/issues/detail?id=75
- cflags = [ "/wd4267" ] # Conversion from size_t to 'type'.
- }
-}
« no previous file with comments | « tools/gn/secondary/third_party/mach_override/BUILD.gn ('k') | tools/gn/secondary/third_party/wtl/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698