Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2644623003: Revert 'Make "compositionend" event fired after setting caret position' (Closed)

Created:
3 years, 11 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews, Shu Chen, yabinh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert 'Make "compositionend" event fired after setting caret position' This reverts http://crrev.com/2493703002, which was bisected to cause Google Docs Korean IME issue 674295. Note the revert is unclean in that the structural changes to InputMethodControllerTest are preserved (only the new tests are deleted) and a new updateStyleAndLayoutIgnorePendingStylesheets was needed because of changes since the original landing. TBR=yosin@chromium.org BUG=674295, 663944 Review-Url: https://codereview.chromium.org/2644623003 Cr-Commit-Position: refs/heads/master@{#444593} Committed: https://chromium.googlesource.com/chromium/src/+/53003b5bb24d266ac78adf0623b2dd07c1ac6e9f

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add updateStyleAndLayoutIgnorePendingStylesheets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -74 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 2 4 chunks +10 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 19 (17 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644623003/40001
3 years, 11 months ago (2017-01-19 00:34:41 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 01:39:23 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/53003b5bb24d266ac78adf0623b2...

Powered by Google App Engine
This is Rietveld 408576698