Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2644543003: Rename device.serial.ParityBit.NO to avoid a clash with NO in objective C. (Closed)

Created:
3 years, 11 months ago by Sam McNally
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename device.serial.ParityBit.NO to avoid a clash with NO in objective C. BUG=682516 Review-Url: https://codereview.chromium.org/2644543003 Cr-Commit-Position: refs/heads/master@{#444663} Committed: https://chromium.googlesource.com/chromium/src/+/fe5b80deb66d94a110ef347739f3f7e8d7d164c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M device/serial/serial.mojom View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_io_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_io_handler_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/serial_io_handler_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/serial/serial_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Sam McNally
+rockot for //device and //extensions +dcheng for the mojom
3 years, 11 months ago (2017-01-19 05:23:21 UTC) #9
dcheng
mojo lgtm
3 years, 11 months ago (2017-01-19 05:26:12 UTC) #10
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-19 05:50:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644543003/1
3 years, 11 months ago (2017-01-19 06:11:22 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 06:16:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe5b80deb66d94a110ef347739f3...

Powered by Google App Engine
This is Rietveld 408576698