Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 264453009: [CSS Shapes] shape-outside polygon can fail when line-top intersects a vertex (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
Reviewers:
Hans Muller, eseidel
CC:
blink-reviews, chrishtr, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., ojan, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] shape-outside polygon can fail when line-top intersects a vertex ShapeInterval now distinguishes between x1==x2 - isEmpty() and x1,x2 haven't been set yet - isUndefined(). Removed the ShapeInterval setX1() and setX2() methods, since they're no longer used. The polygon algorithm for computing excluded intervals now ignores horizontal edges. It also ignores edges whose lower vertex matches the top of the line, if the edge's Y direction is upwards (away from the top of the line). The rationale for this was explained here: http://hansmuller-webkit.blogspot.com/2012/11/revised-horizontal-box-algorithm.html This is a merge of http://trac.webkit.org/changeset/167931 by Hans Muller <hmuller@adobe.com>;. BUG=368686 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173038

Patch Set 1 #

Patch Set 2 : Remove webkit prefix #

Patch Set 3 : Remove -webkit-font-smoothing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -20 lines) Patch
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-polygon-zero-vertex.html View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-polygon-zero-vertex-expected.html View 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/rendering/shapes/PolygonShape.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/rendering/shapes/ShapeInterval.h View 3 chunks +21 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rwlbuis
PTAL, ported over from WebKit, okayed by the original author, Hans Muller.
6 years, 7 months ago (2014-04-30 16:51:56 UTC) #1
Hans Muller
On 2014/04/30 16:51:56, rwlbuis wrote: > PTAL, ported over from WebKit, okayed by the original ...
6 years, 7 months ago (2014-04-30 21:08:46 UTC) #2
eseidel
lgtm
6 years, 7 months ago (2014-04-30 21:16:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/264453009/40001
6 years, 7 months ago (2014-04-30 21:17:16 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 22:24:39 UTC) #5
Message was sent while issue was closed.
Change committed as 173038

Powered by Google App Engine
This is Rietveld 408576698