Source/core/rendering/shapes/PolygonShape.cpp - Issue 264453009: [CSS Shapes] shape-outside polygon can fail when line-top intersects a vertex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/PolygonShape.cpp

Issue 264453009: [CSS Shapes] shape-outside polygon can fail when line-top intersects a vertex (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove -webkit-font-smoothing Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/shapes/shape-outside-floats/shape-outside-polygon-zero-vertex-expected.html ('k') | Source/core/rendering/shapes/ShapeInterval.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/shapes/PolygonShape.cpp

diff --git a/Source/core/rendering/shapes/PolygonShape.cpp b/Source/core/rendering/shapes/PolygonShape.cpp

index 15fd9bd451b0b58abc4f7dfb467e7225cb9827b2..0160f85b93a2a68304321a31e7120017db12b89b 100644

--- a/Source/core/rendering/shapes/PolygonShape.cpp

+++ b/Source/core/rendering/shapes/PolygonShape.cpp

@@ -69,7 +69,7 @@ float OffsetPolygonEdge::xIntercept(float y) const

FloatShapeInterval OffsetPolygonEdge::clippedEdgeXRange(float y1, float y2) const

{

- if (!overlapsYRange(y1, y2))

+ if (!overlapsYRange(y1, y2) || (y1 == maxY() && vertex2().y() < vertex1().y()))

return FloatShapeInterval();

if (isWithinYRange(y1, y2))

@@ -135,6 +135,8 @@ void PolygonShape::getExcludedIntervals(LayoutUnit logicalTop, LayoutUnit logica

FloatShapeInterval excludedInterval;

for (unsigned i = 0; i < overlappingEdges.size(); i++) {

const FloatPolygonEdge& edge = *(overlappingEdges[i]);

+ if (edge.maxY() == edge.minY())

+ continue;

if (!shapeMargin()) {

excludedInterval.unite(OffsetPolygonEdge(edge, FloatSize()).clippedEdgeXRange(y1, y2));

} else {