Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2644463008: Remove leftover conflict markers from proxy_service_unittest.cc (Closed)

Created:
3 years, 11 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 11 months ago
Reviewers:
davidben
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove leftover conflict markers from proxy_service_unittest.cc These were commented out instead of deleted after the conflict was resolved in http://crrev.com/426450 BUG=478934 Review-Url: https://codereview.chromium.org/2644463008 Cr-Commit-Position: refs/heads/master@{#444984} Committed: https://chromium.googlesource.com/chromium/src/+/5bd3b4bb359c6378ffcb3c31d7ad2166ad09534f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M net/proxy/proxy_service_unittest.cc View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
aelias_OOO_until_Jul13
Hi davidben@, PTAL.
3 years, 11 months ago (2017-01-20 03:16:25 UTC) #4
davidben
lgtm
3 years, 11 months ago (2017-01-20 04:35:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644463008/1
3 years, 11 months ago (2017-01-20 04:46:53 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 04:51:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5bd3b4bb359c6378ffcb3c31d7ad...

Powered by Google App Engine
This is Rietveld 408576698