Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2644393002: [DevTools] Implement dock to left. (Closed)

Created:
3 years, 11 months ago by dgozman
Modified:
3 years, 11 months ago
Reviewers:
einbinder
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Implement dock to left. BUG=134282 Review-Url: https://codereview.chromium.org/2644393002 Cr-Commit-Position: refs/heads/master@{#445213} Committed: https://chromium.googlesource.com/chromium/src/+/a9f46170339ac563b04cf74f72975a507bbe1cde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -44 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/DockController.js View 6 chunks +7 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js View 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/splitWidget.css View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dgozman
Take a look please.
3 years, 11 months ago (2017-01-20 21:55:53 UTC) #2
einbinder
lgtm
3 years, 11 months ago (2017-01-20 22:10:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644393002/1
3 years, 11 months ago (2017-01-20 22:15:42 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 23:53:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9f46170339ac563b04cf74f7297...

Powered by Google App Engine
This is Rietveld 408576698