Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2644373004: DevTools: Slim down timeline overview height (Closed)

Created:
3 years, 11 months ago by alph
Modified:
3 years, 11 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Slim down timeline overview height Review-Url: https://codereview.chromium.org/2644373004 Cr-Commit-Position: refs/heads/master@{#445269} Committed: https://chromium.googlesource.com/chromium/src/+/799d1b122128aa137ee7c4a66f7e65eaf39b0485

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -50 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 3 chunks +32 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css View 1 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alph
3 years, 11 months ago (2017-01-20 21:34:47 UTC) #2
caseq
can we have a screenshot for this one? https://codereview.chromium.org/2644373004/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/2644373004/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode170 third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js:170: requests.forEach(drawRequest); ...
3 years, 11 months ago (2017-01-20 23:07:02 UTC) #3
alph
all done. ptal
3 years, 11 months ago (2017-01-21 01:42:33 UTC) #4
alph
ss: https://drive.google.com/a/google.com/file/d/0ByLjXIa7NKi9M1RzemRMV045WjQ/view?usp=sharing
3 years, 11 months ago (2017-01-21 01:46:06 UTC) #5
pfeldman
lgtm
3 years, 11 months ago (2017-01-21 02:17:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644373004/20001
3 years, 11 months ago (2017-01-21 02:18:45 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 04:08:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/799d1b122128aa137ee7c4a66f7e...

Powered by Google App Engine
This is Rietveld 408576698