test-parsing/NoPessimisticContextAllocation: add a missing test

test-parsing/NoPessimisticContextAllocation: add a missing test

The "sloppy eval in default param" cases will be useful for the future
tests which assert that parser and preparser produce the same scopes.

BUG=v8:5501, v8:5516
Review-Url: https://codereview.chromium.org/2644333002
Cr-Commit-Position: refs/heads/master@{#42625}
Committed: https://chromium.googlesource.com/v8/v8/+/29ede2bf0efd11df69626f4ea47a77970c220dfd

[marja, 2017-01-20 12:04:29]

Description was changed from

==========
test-parsing/NoPessimisticContextAllocation: add missing cases.

The "sloppy eval in default param" cases will be useful for the future
tests which assert that parser and preparser produce the same scopes.

BUG=v8:5501, v8:5516
==========

to

==========
test-parsing/NoPessimisticContextAllocation: add a missing test

The "sloppy eval in default param" cases will be useful for the future
tests which assert that parser and preparser produce the same scopes.

BUG=v8:5501, v8:5516
==========

[marja, 2017-01-20 12:04:29]

marja@chromium.org changed reviewers:
+ adamk@chromium.org

[marja, 2017-01-20 12:04:59]

ptal

(I noticed that these were missing when developing the next step...)

[adamk, 2017-01-20 17:55:41]

lgtm

https://codereview.chromium.org/2644333002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/2644333002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:8720: {"", "function inner2(a = eval(\"\")) { }",
true},
You could use eval('') to avoid the quoting and make this slightly easier to
read. Same below.

[marja, 2017-01-24 09:40:28]

https://codereview.chromium.org/2644333002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/2644333002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:8720: {"", "function inner2(a = eval(\"\")) { }",
true},
On 2017/01/20 17:55:41, adamk wrote:
> You could use eval('') to avoid the quoting and make this slightly easier to
> read. Same below.

Done.

[marja, 2017-01-24 09:40:33]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-24 09:40:33]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2644333002/#ps20001
(title: "code review (adamk@)")

[commit-bot: I haz the power, 2017-01-24 09:40:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 10:14:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485250833339930,
"parent_rev": "3dea55b41379a606d7a1f5f33bbdda69e440f2b6", "commit_rev":
"29ede2bf0efd11df69626f4ea47a77970c220dfd"}

[commit-bot: I haz the power, 2017-01-24 10:14:50]

Description was changed from

==========
test-parsing/NoPessimisticContextAllocation: add a missing test

The "sloppy eval in default param" cases will be useful for the future
tests which assert that parser and preparser produce the same scopes.

BUG=v8:5501, v8:5516
==========

to

==========
test-parsing/NoPessimisticContextAllocation: add a missing test

The "sloppy eval in default param" cases will be useful for the future
tests which assert that parser and preparser produce the same scopes.

BUG=v8:5501, v8:5516

Review-Url: https://codereview.chromium.org/2644333002
Cr-Commit-Position: refs/heads/master@{#42625}
Committed:
https://chromium.googlesource.com/v8/v8/+/29ede2bf0efd11df69626f4ea47a77970c2...
==========

[commit-bot: I haz the power, 2017-01-24 10:14:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/29ede2bf0efd11df69626f4ea47a77970c2...