Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2644323002: [wasm] Use the official opcode names everywhere. (Closed)

Created:
3 years, 11 months ago by titzer
Modified:
3 years, 11 months ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use the official opcode names everywhere. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2644323002 Cr-Commit-Position: refs/heads/master@{#42557} Committed: https://chromium.googlesource.com/v8/v8/+/ba4e31639232c65a8d5f9b01030e7fcceb45b9f6

Patch Set 1 #

Patch Set 2 : Fix wasm-macro-gen.h #

Patch Set 3 : [wasm] Use the official opcode names everywhere. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -202 lines) Patch
M src/compiler/wasm-compiler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/wasm/function-body-decoder.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 3 chunks +62 lines, -63 lines 0 comments Download
M src/wasm/wasm-opcodes.cc View 1 chunk +206 lines, -20 lines 0 comments Download
M src/wasm/wasm-text.cc View 6 chunks +6 lines, -106 lines 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/unittests/wasm/wasm-opcodes-unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
titzer
3 years, 11 months ago (2017-01-20 11:51:36 UTC) #1
Clemens Hammacher
This is finally putting the opcode names where they belong! Lgtm.
3 years, 11 months ago (2017-01-20 13:24:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644323002/40001
3 years, 11 months ago (2017-01-20 13:26:46 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 13:28:35 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/ba4e31639232c65a8d5f9b01030e7fcceb4...

Powered by Google App Engine
This is Rietveld 408576698