third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js - Issue 2644233007: DevTools: Use real focus in TreeOutline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2644233007: DevTools: Use real focus in TreeOutline (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js ('K') | « third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/treeoutline.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

index 6433cfdb128efaf2220d688a0460728948f89843..8ab06306cb6fb5f8da9814a9175fabe680624049 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

@@ -825,6 +825,7 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

return;

treeOutline.runPendingUpdates();

+ treeOutline.focus();

pfeldman 2017/01/30 18:43:07 Why are we losing focus that this becomes necessar

einbinder 2017/02/01 22:51:35 Removed, see https://codereview.chromium.org/26744

// Search for the attribute's position, and then decide where to move to.

var attributes = this._node.attributes();