third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js - Issue 2644233007: DevTools: Use real focus in TreeOutline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 2644233007: DevTools: Use real focus in TreeOutline (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/accessibility/accessibilityNode.css ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('j') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

index 21f0f9756b13289e5e1b850ea0b01415ea575242..aa92643305b36c8ea789075f3616d61459b3b5be 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

@@ -37,11 +37,10 @@ Components.ObjectPropertiesSection = class extends UI.TreeOutlineInShadow {

* @param {!Array.<!SDK.RemoteObjectProperty>=} extraProperties

constructor(object, title, linkifier, emptyPlaceholder, ignoreHasOwnProperty, extraProperties) {

- super();

+ super(true);

this._object = object;

this._editable = true;

this.hideOverflow();

- this.setFocusable(false);

pfeldman 2017/01/30 18:43:07 I like it the way it was

einbinder 2017/02/01 22:51:35 Done.

this._objectTreeElement = new Components.ObjectPropertiesSection.RootElement(

object, linkifier, emptyPlaceholder, ignoreHasOwnProperty, extraProperties);

this.appendChild(this._objectTreeElement);