Integration tests for WebStateDelegate::OnAuthRequired callback.

Integration tests for WebStateDelegate::OnAuthRequired callback.

BUG=675001
Review-Url: https://codereview.chromium.org/2644223002
Cr-Commit-Position: refs/heads/master@{#445264}
Committed: https://chromium.googlesource.com/chromium/src/+/9bac59183b8d603d2dfdde42d7f9c20c1f62be5c

[Eugene But (OOO till 7-30), 2017-01-19 22:40:12]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 22:40:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-01-19 23:38:20]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org, michaeldo@chromium.org

[commit-bot: I haz the power, 2017-01-19 23:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 23:51:46]

Dry run: This issue passed the CQ dry run.

[baxley, 2017-01-20 16:17:09]

lgtm

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
File ios/web/web_state/http_auth_inttest.mm (right):

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:31: // Loads a page with URL and wait for
OnAuthRequired callback.
nit:s/wait/waits

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:38: // Authentificates and waits until
the page finish loading.
nit:s/finish/finishes

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:38: // Authentificates and waits until
the page finish loading.
nit:s/Authentificates/Authenticates

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:49: // Tests sucessfull basic
authentication.
nit: s/sucessfull/successful

[Eugene But (OOO till 7-30), 2017-01-20 22:20:22]

Thanks!

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
File ios/web/web_state/http_auth_inttest.mm (right):

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:31: // Loads a page with URL and wait for
OnAuthRequired callback.
On 2017/01/20 16:17:09, baxley wrote:
> nit:s/wait/waits

Done.

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:38: // Authentificates and waits until
the page finish loading.
On 2017/01/20 16:17:09, baxley wrote:
> nit:s/Authentificates/Authenticates

Done.

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:38: // Authentificates and waits until
the page finish loading.
On 2017/01/20 16:17:09, baxley wrote:
> nit:s/finish/finishes

Done.

https://codereview.chromium.org/2644223002/diff/20001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:49: // Tests sucessfull basic
authentication.
On 2017/01/20 16:17:09, baxley wrote:
> nit: s/sucessfull/successful

Done.

[Eugene But (OOO till 7-30), 2017-01-20 22:20:26]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2017-01-20 22:20:39]

michaeldo@?

[commit-bot: I haz the power, 2017-01-20 22:20:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaeldo, 2017-01-20 23:48:24]

lgtm with below comments.

https://codereview.chromium.org/2644223002/diff/40001/ios/web/test/web_int_te...
File ios/web/test/web_int_test.mm (right):

https://codereview.chromium.org/2644223002/diff/40001/ios/web/test/web_int_te...
ios/web/test/web_int_test.mm:96: observer_ = base::WrapUnique(new
IntTestWebStateObserver(web_state()));
Use MakeUnique instead here?

// MakeUnique<T>(args) should be preferred over WrapUnique(new T(args)): bare
// calls to `new` should be treated with scrutiny.

Ref: https://cs.chromium.org/chromium/src/base/memory/ptr_util.h?rcl=0&l=43

https://codereview.chromium.org/2644223002/diff/40001/ios/web/web_state/http_...
File ios/web/web_state/http_auth_inttest.mm (right):

https://codereview.chromium.org/2644223002/diff/40001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:25:
web_state_delegate_.ClearLastAuthenticationRequest();
Should ClearLastAuthenticationRequest() be called outside of this method before
the LoadURL call in order to remove the potential for any flake?

[commit-bot: I haz the power, 2017-01-21 00:08:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:08:34]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-01-21 01:42:10]

Thanks!

https://codereview.chromium.org/2644223002/diff/40001/ios/web/test/web_int_te...
File ios/web/test/web_int_test.mm (right):

https://codereview.chromium.org/2644223002/diff/40001/ios/web/test/web_int_te...
ios/web/test/web_int_test.mm:96: observer_ = base::WrapUnique(new
IntTestWebStateObserver(web_state()));
On 2017/01/20 23:48:24, michaeldo wrote:
> Use MakeUnique instead here?
> 
> // MakeUnique<T>(args) should be preferred over WrapUnique(new T(args)): bare
> // calls to `new` should be treated with scrutiny.
> 
> Ref: https://cs.chromium.org/chromium/src/base/memory/ptr_util.h?rcl=0&l=43

Done.

https://codereview.chromium.org/2644223002/diff/40001/ios/web/web_state/http_...
File ios/web/web_state/http_auth_inttest.mm (right):

https://codereview.chromium.org/2644223002/diff/40001/ios/web/web_state/http_...
ios/web/web_state/http_auth_inttest.mm:25:
web_state_delegate_.ClearLastAuthenticationRequest();
On 2017/01/20 23:48:24, michaeldo wrote:
> Should ClearLastAuthenticationRequest() be called outside of this method
before
> the LoadURL call in order to remove the potential for any flake?
Moving this code outside will change the behavior so this method will not wait
in all cases. I think calling ClearLastAuthenticationRequest should not be a
prerequisite for calling WaitForOnAuthRequiredCallback.

[Eugene But (OOO till 7-30), 2017-01-21 01:42:16]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-01-21 01:42:16]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org,
michaeldo@chromium.org
Link to the patchset: https://codereview.chromium.org/2644223002/#ps60001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2017-01-21 01:42:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 03:25:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484962936148310,
"parent_rev": "cb7a5bd35751e0a3ddc69330fb5e218a8a452a44", "commit_rev":
"9bac59183b8d603d2dfdde42d7f9c20c1f62be5c"}

[commit-bot: I haz the power, 2017-01-21 03:26:14]

Description was changed from

==========
Integration tests for WebStateDelegate::OnAuthRequired callback.

BUG=675001
==========

to

==========
Integration tests for WebStateDelegate::OnAuthRequired callback.

BUG=675001

Review-Url: https://codereview.chromium.org/2644223002
Cr-Commit-Position: refs/heads/master@{#445264}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bac59183b8d603d2dfdde42d7f9...
==========

[commit-bot: I haz the power, 2017-01-21 03:26:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9bac59183b8d603d2dfdde42d7f9...