Remove ScopedVector in //component/undo

Remove ScopedVector in //component/undo

BUG=554289
Review-Url: https://codereview.chromium.org/2644203003
Cr-Commit-Position: refs/heads/master@{#446171}
Committed: https://chromium.googlesource.com/chromium/src/+/da6df4de66659c8115e3cfb08b593dc3e4726d8d

[ke.he, 2017-01-20 03:48:58]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 03:49:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 05:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 05:05:42]

Dry run: This issue passed the CQ dry run.

[ke.he, 2017-01-20 05:12:17]

ke.he@intel.com changed reviewers:
+ sky@chromium.org

[ke.he, 2017-01-20 05:12:17]

Hi, sky@, I removed the depreciated ScopedVector, Could you PTAL? Thanks very
much.

[sky, 2017-01-20 16:57:06]

https://codereview.chromium.org/2644203003/diff/1/components/undo/undo_manage...
File components/undo/undo_manager.cc (right):

https://codereview.chromium.org/2644203003/diff/1/components/undo/undo_manage...
components/undo/undo_manager.cc:43: for (auto ri = operations_.rbegin(); ri !=
operations_.rend(); ++ri) {
no {}

https://codereview.chromium.org/2644203003/diff/1/components/undo/undo_manage...
components/undo/undo_manager.cc:206: std::vector<UndoOperation*>
UndoManager::ConvertToRawPtrVector(
Move this into anonymous namespace at top of file.

https://codereview.chromium.org/2644203003/diff/1/components/undo/undo_manage...
components/undo/undo_manager.cc:209: std::transform(
Use a for loop, same amount of code and more readable.

[ke.he, 2017-01-22 03:14:37]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 03:14:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-22 03:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-22 03:21:12]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[ke.he, 2017-01-22 03:25:51]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 03:26:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-22 03:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-22 03:45:14]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[ke.he, 2017-01-22 06:21:49]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 06:21:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-22 07:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-22 07:38:00]

Dry run: This issue passed the CQ dry run.

[ke.he, 2017-01-22 07:44:08]

Hi, Sky@, Thanks! CL updated, PTAL.

https://codereview.chromium.org/2644203003/diff/1/components/undo/undo_manage...
File components/undo/undo_manager.cc (right):

https://codereview.chromium.org/2644203003/diff/1/components/undo/undo_manage...
components/undo/undo_manager.cc:43: for (auto ri = operations_.rbegin(); ri !=
operations_.rend(); ++ri) {
On 2017/01/20 16:57:05, sky wrote:
> no {}

Done.

https://codereview.chromium.org/2644203003/diff/1/components/undo/undo_manage...
components/undo/undo_manager.cc:206: std::vector<UndoOperation*>
UndoManager::ConvertToRawPtrVector(
On 2017/01/20 16:57:05, sky wrote:
> Move this into anonymous namespace at top of file.

Done.

https://codereview.chromium.org/2644203003/diff/1/components/undo/undo_manage...
components/undo/undo_manager.cc:209: std::transform(
On 2017/01/20 16:57:05, sky wrote:
> Use a for loop, same amount of code and more readable.

Done.

[sky, 2017-01-23 16:22:16]

https://codereview.chromium.org/2644203003/diff/60001/components/undo/undo_ma...
File components/undo/undo_manager.cc (right):

https://codereview.chromium.org/2644203003/diff/60001/components/undo/undo_ma...
components/undo/undo_manager.cc:149: std::vector<UndoOperation*>
UndoManager::GetAllUndoOperations() const {
This function is only used in tests. Please move to the test that needs it and
friend a class named UndoManagerTestApi that exposes this function.

[ke.he, 2017-01-24 08:07:24]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 08:07:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ke.he, 2017-01-24 09:01:13]

Hi, Sky@, CL updated, PTAL.
Thanks!

https://codereview.chromium.org/2644203003/diff/60001/components/undo/undo_ma...
File components/undo/undo_manager.cc (right):

https://codereview.chromium.org/2644203003/diff/60001/components/undo/undo_ma...
components/undo/undo_manager.cc:149: std::vector<UndoOperation*>
UndoManager::GetAllUndoOperations() const {
On 2017/01/23 16:22:16, sky wrote:
> This function is only used in tests. Please move to the test that needs it and
> friend a class named UndoManagerTestApi that exposes this function.

Done.
ConvertToRawPtrVector() is moved into test file too.

[commit-bot: I haz the power, 2017-01-24 09:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 09:05:43]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-24 18:15:53]

https://codereview.chromium.org/2644203003/diff/80001/components/undo/undo_ma...
File components/undo/undo_manager_test.cc (right):

https://codereview.chromium.org/2644203003/diff/80001/components/undo/undo_ma...
components/undo/undo_manager_test.cc:33: };
private: DISALLOW_IMPLICIT_CONSTRUCTORS

[ke.he, 2017-01-25 15:00:54]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 15:01:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ke.he, 2017-01-25 15:03:51]

Sky@, Thanks for your review:)
CL updated, PTAL.

https://codereview.chromium.org/2644203003/diff/80001/components/undo/undo_ma...
File components/undo/undo_manager_test.cc (right):

https://codereview.chromium.org/2644203003/diff/80001/components/undo/undo_ma...
components/undo/undo_manager_test.cc:33: };
On 2017/01/24 18:15:52, sky wrote:
> private: DISALLOW_IMPLICIT_CONSTRUCTORS

Done.

[commit-bot: I haz the power, 2017-01-25 15:42:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 15:42:58]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-25 16:42:12]

LGTM

[ke.he, 2017-01-26 00:10:38]

The CQ bit was checked by ke.he@intel.com

[commit-bot: I haz the power, 2017-01-26 00:11:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 00:20:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485389438935090,
"parent_rev": "76ed9ed0d250af589239a52d427a1f72991dee71", "commit_rev":
"da6df4de66659c8115e3cfb08b593dc3e4726d8d"}

[commit-bot: I haz the power, 2017-01-26 00:20:45]

Description was changed from

==========
Remove ScopedVector in //component/undo

BUG=554289
==========

to

==========
Remove ScopedVector in //component/undo

BUG=554289

Review-Url: https://codereview.chromium.org/2644203003
Cr-Commit-Position: refs/heads/master@{#446171}
Committed:
https://chromium.googlesource.com/chromium/src/+/da6df4de66659c8115e3cfb08b59...
==========

[commit-bot: I haz the power, 2017-01-26 00:20:48]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/da6df4de66659c8115e3cfb08b59...