Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: content/child/service_worker/service_worker_dispatcher.h

Issue 26442004: Service worker registration error support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update to reflect changes from dependent bug Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_dispatcher.h
diff --git a/content/child/service_worker/service_worker_dispatcher.h b/content/child/service_worker/service_worker_dispatcher.h
index d3d8fc42d0500b9f1232daf67e6cb8ad8502b008..48cc50ebcdd688b1d66d43e5bf9cae056bb8e8a5 100644
--- a/content/child/service_worker/service_worker_dispatcher.h
+++ b/content/child/service_worker/service_worker_dispatcher.h
@@ -8,6 +8,7 @@
#include "base/id_map.h"
#include "base/memory/ref_counted.h"
#include "base/strings/string16.h"
+#include "third_party/WebKit/public/platform/WebServiceWorkerError.h"
#include "third_party/WebKit/public/platform/WebServiceWorkerProvider.h"
#include "webkit/child/worker_task_runner.h"
@@ -51,11 +52,13 @@ class ServiceWorkerDispatcher : public webkit_glue::WorkerTaskRunner::Observer {
// webkit_glue::WorkerTaskRunner::Observer implementation.
virtual void OnWorkerRunLoopStopped() OVERRIDE;
- void OnServiceWorkerRegistered(int32 thread_id,
- int32 request_id,
- int64 service_worker_id);
- void OnServiceWorkerUnregistered(int32 thread_id,
- int32 request_id);
+ void OnRegistered(int32 thread_id, int32 request_id, int64 service_worker_id);
Tom Sepez 2013/10/25 18:46:59 nit: I liked the old names better. Up to you.
+ void OnUnregistered(int32 thread_id,
+ int32 request_id);
+ void OnRegistrationError(int32 thread_id,
+ int32 request_id,
+ WebKit::WebServiceWorkerError::ErrorType error_type,
+ string16 message);
IDMap<WebKit::WebServiceWorkerProvider::WebServiceWorkerCallbacks,
IDMapOwnPointer> pending_callbacks_;

Powered by Google App Engine
This is Rietveld 408576698