Index: content/common/service_worker_messages.h |
diff --git a/content/common/service_worker_messages.h b/content/common/service_worker_messages.h |
index a0e576124f19940eb8f8b947c3d01aadc95cd23b..ca458e6489f7a6e8e8ade9922b0fd69227675315 100644 |
--- a/content/common/service_worker_messages.h |
+++ b/content/common/service_worker_messages.h |
@@ -8,9 +8,15 @@ |
#include "ipc/ipc_message_macros.h" |
#include "ipc/ipc_param_traits.h" |
#include "url/gurl.h" |
+#include "third_party/WebKit/public/platform/WebServiceWorkerError.h" |
Tom Sepez
2013/10/25 18:46:59
nit: include order.
|
+ |
+#undef IPC_MESSAGE_EXPORT |
+#define IPC_MESSAGE_EXPORT CONTENT_EXPORT |
#define IPC_MESSAGE_START ServiceWorkerMsgStart |
+IPC_ENUM_TRAITS(WebKit::WebServiceWorkerError::ErrorType) |
+ |
// Messages sent from the child process to the browser. |
IPC_MESSAGE_CONTROL4(ServiceWorkerHostMsg_RegisterServiceWorker, |
@@ -36,3 +42,14 @@ IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_ServiceWorkerRegistered, |
IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_ServiceWorkerUnregistered, |
int32 /* thread_id */, |
int32 /* request_id */) |
+ |
+// Any kind of registration error from RegisterServiceWorker / |
Tom Sepez
2013/10/25 18:46:59
nit: this isn't a sentence, its a sentence fragmen
alecflett
2013/10/25 20:05:02
Done.
|
+// UnregisterServiceWorker above. This can expand to include the |
+// actual reason for the error, or even be split if there is a |
Tom Sepez
2013/10/25 18:46:59
nit: do you mean, "In the future, this could expan
alecflett
2013/10/25 20:05:02
Done.
|
+// significant difference between registration and unregistration |
+// errors. |
+IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_ServiceWorkerRegistrationError, |
+ int32 /* thread_id */, |
+ int32 /* request_id */, |
+ WebKit::WebServiceWorkerError::ErrorType /* code */, |
+ string16 /* message */) |
Tom Sepez
2013/10/25 18:46:59
nit: do we need to pass a string here? Does it con
alecflett
2013/10/25 20:05:02
Yes, there is such a mapping in Blink.
michaeln
2013/10/25 21:41:25
There is a generic mapping from Type to string, bu
|