Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2644153002:
Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. (Closed)
|
Created:
3 years, 11 months ago by Byoungkwon Ko Modified:
3 years, 10 months ago Reviewers:
haraken CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove SetSinkIdResolver timer to frame-specific TaskRunnerTimer.
Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer.
This associates it with the frame's MiscPlatformAPI timer task queue.
It is a speced task, so we should use MiscPlatformAPI.[1]
[1] The spec link: https://w3c.github.io/mediacapture-output/#htmlmediaelement-
extensions
This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame
scheduler:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY
BUG=624694
Review-Url: https://codereview.chromium.org/2644153002
Cr-Commit-Position: refs/heads/master@{#448184}
Committed: https://chromium.googlesource.com/chromium/src/+/89d445684f181b98567d6181670b6f84de2c981d
Patch Set 1 #Patch Set 2 : Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. #Messages
Total messages: 37 (28 generated)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gogag2@gmail.com changed reviewers: + haraken@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Would you explain why you chose the TaskType in the CL description? It will require some investigation on the spec. I think this is a speced task and should not use UnspecedTimer.
Description was changed from ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. BUG=624694 ========== to ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. [1] The spec link:https://w3c.github.io/mediacapture-output/#htmlmediaelement- extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink- dev/80dsbEEOcWY BUG=624694 ==========
Description was changed from ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. [1] The spec link:https://w3c.github.io/mediacapture-output/#htmlmediaelement- extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink- dev/80dsbEEOcWY BUG=624694 ========== to ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. [1] The spec link:https://w3c.github.io/mediacapture-output/#htmlmediaelement- extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 ==========
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. [1] The spec link:https://w3c.github.io/mediacapture-output/#htmlmediaelement- extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 ========== to ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. It is not a speced task, so we should use UnspecedTimer. [1] The spec link: https://w3c.github.io/mediacapture-output/#htmlmediaelement-extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 ==========
Description was changed from ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. It is not a speced task, so we should use UnspecedTimer. [1] The spec link: https://w3c.github.io/mediacapture-output/#htmlmediaelement-extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 ========== to ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. It is not a speced task, so we should use UnspecedTimer.[1] [1] The spec link: https://w3c.github.io/mediacapture-output/#htmlmediaelement- extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 ==========
On 2017/01/20 04:59:42, haraken wrote: > Would you explain why you chose the TaskType in the CL description? It will > require some investigation on the spec. > > I think this is a speced task and should not use UnspecedTimer. haraken@ I updated description, but I don't know what task we should use. When I try to find task on the spec, I can't find well..; Plz help me what task we should use. Thanks.
On 2017/02/03 17:20:26, Byoungkwon Ko wrote: > On 2017/01/20 04:59:42, haraken wrote: > > Would you explain why you chose the TaskType in the CL description? It will > > require some investigation on the spec. > > > > I think this is a speced task and should not use UnspecedTimer. > > haraken@ > > I updated description, but I don't know what task we should use. > When I try to find task on the spec, I can't find well..; > Plz help me what task we should use. > Thanks. I think this is a task defined in the "Run the following substeps in parallel" part in https://w3c.github.io/mediacapture-output/#htmlmediaelement-. So I'd use MiskPlatformAPI. With that change, LGTM.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's UnspecedTimer timer task queue. It is not a speced task, so we should use UnspecedTimer.[1] [1] The spec link: https://w3c.github.io/mediacapture-output/#htmlmediaelement- extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 ========== to ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's MiscPlatformAPI timer task queue. It is a speced task, so we should use MiscPlatformAPI.[1] [1] The spec link: https://w3c.github.io/mediacapture-output/#htmlmediaelement- extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
On 2017/02/03 18:19:52, haraken wrote: > On 2017/02/03 17:20:26, Byoungkwon Ko wrote: > > On 2017/01/20 04:59:42, haraken wrote: > > > Would you explain why you chose the TaskType in the CL description? It will > > > require some investigation on the spec. > > > > > > I think this is a speced task and should not use UnspecedTimer. > > > > haraken@ > > > > I updated description, but I don't know what task we should use. > > When I try to find task on the spec, I can't find well..; > > Plz help me what task we should use. > > Thanks. > > I think this is a task defined in the "Run the following substeps in parallel" > part in https://w3c.github.io/mediacapture-output/#htmlmediaelement-. > > So I'd use MiskPlatformAPI. With that change, LGTM. I changed it to MiscPlatformAPI. Thanks : )
The CQ bit was checked by gogag2@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2644153002/#ps20001 (title: "Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by gogag2@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486304861821660,
"parent_rev": "604a36b20d9ffe65380031f3f708d859d81f71be", "commit_rev":
"89d445684f181b98567d6181670b6f84de2c981d"}
Message was sent while issue was closed.
Description was changed from ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's MiscPlatformAPI timer task queue. It is a speced task, so we should use MiscPlatformAPI.[1] [1] The spec link: https://w3c.github.io/mediacapture-output/#htmlmediaelement- extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 ========== to ========== Move SetSinkIdResolver timer to frame-specific TaskRunnerTimer. Move SetSinkIdResolver timer m_timer to frame-specific TaskRunnerTimer. This associates it with the frame's MiscPlatformAPI timer task queue. It is a speced task, so we should use MiscPlatformAPI.[1] [1] The spec link: https://w3c.github.io/mediacapture-output/#htmlmediaelement- extensions This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 Review-Url: https://codereview.chromium.org/2644153002 Cr-Commit-Position: refs/heads/master@{#448184} Committed: https://chromium.googlesource.com/chromium/src/+/89d445684f181b98567d6181670b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/89d445684f181b98567d6181670b... |
