Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2644143004:
FasterLocationReload: Update Field Trial Testing Configuration (Closed)
|
Created:
3 years, 11 months ago by Takashi Toyoshima Modified:
3 years, 11 months ago Reviewers:
Alexei Svitkine (slow) CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFasterLocationReload: Update Field Trial Testing Configuration
To setup the field trial to be ready for Beta channel, let me
update the configuration to run tests under the condition that
enables the feature.
BUG=670237
Review-Url: https://codereview.chromium.org/2644143004
Cr-Commit-Position: refs/heads/master@{#445459}
Committed: https://chromium.googlesource.com/chromium/src/+/84b31e5ea7c346f66228ceb1c38034e8ec8425b6
Patch Set 1 #
Total comments: 2
Patch Set 2 : enable_features #Messages
Total messages: 19 (13 generated)
Description was changed from ========== FasterLocationReload: Update Field Trial Testing Configuration To setup the field trial to be ready for Beta channel, let me update the configuration to run tests under the condition that enables the feature. BUG=670237 ========== to ========== FasterLocationReload: Update Field Trial Testing Configuration To setup the field trial to be ready for Beta channel, let me update the configuration to run tests under the condition that enables the feature. BUG=670237 ==========
toyoshim@chromium.org changed reviewers: + asvitkine@chromium.org
ptal
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2644143004/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2644143004/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:795: "name": "Enabled" You're missing the enable_features line here.
https://codereview.chromium.org/2644143004/diff/1/testing/variations/fieldtri... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2644143004/diff/1/testing/variations/fieldtri... testing/variations/fieldtrial_testing_config.json:795: "name": "Enabled" On 2017/01/20 17:34:04, Alexei Svitkine (slow) wrote: > You're missing the enable_features line here. Done.
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485202082935250,
"parent_rev": "9b01d9a9432324f635b6b1132f88c1450a8f0314", "commit_rev":
"84b31e5ea7c346f66228ceb1c38034e8ec8425b6"}
Message was sent while issue was closed.
Description was changed from ========== FasterLocationReload: Update Field Trial Testing Configuration To setup the field trial to be ready for Beta channel, let me update the configuration to run tests under the condition that enables the feature. BUG=670237 ========== to ========== FasterLocationReload: Update Field Trial Testing Configuration To setup the field trial to be ready for Beta channel, let me update the configuration to run tests under the condition that enables the feature. BUG=670237 Review-Url: https://codereview.chromium.org/2644143004 Cr-Commit-Position: refs/heads/master@{#445459} Committed: https://chromium.googlesource.com/chromium/src/+/84b31e5ea7c346f66228ceb1c380... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/84b31e5ea7c346f66228ceb1c380... |
