Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2644133004: Fix unused lambda captures in //content. (Closed)

Created:
3 years, 11 months ago by krasin1
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unused lambda captures in //content. Clang just got a new warning about unused lambda captures, and that requires us to clean all places with this issue across all the Chromium code base. This CL fixes all such cases in //content. An example of a code that is no longer considered normal is auto g = [i, j]() { printf("%d\n", i); }; in which j is never used in the lambda and therefore its capture is unnecessary. BUG=681136 Review-Url: https://codereview.chromium.org/2644133004 Cr-Commit-Position: refs/heads/master@{#445061} Committed: https://chromium.googlesource.com/chromium/src/+/bbbf64cf6fa9c2ec032d680d1fbb08a60e5915ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/presentation/presentation_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
krasin1
3 years, 11 months ago (2017-01-19 23:08:47 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-20 07:32:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644133004/1
3 years, 11 months ago (2017-01-20 15:35:54 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 15:39:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bbbf64cf6fa9c2ec032d680d1fbb...

Powered by Google App Engine
This is Rietveld 408576698