Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2644123003: Move ios/ui/suggestions to ios/ui/content_suggestions (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, lpromero+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ios/ui/suggestions to ios/ui/content_suggestions BUG=679369 Review-Url: https://codereview.chromium.org/2644123003 Cr-Commit-Position: refs/heads/master@{#445991} Committed: https://chromium.googlesource.com/chromium/src/+/9756a18af5acb7fcc5f674b7908d9daeaf3357ba

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -2014 lines) Patch
M ios/chrome/browser/content_suggestions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
A ios/chrome/browser/ui/content_suggestions/BUILD.gn View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm View 6 chunks +6 lines, -6 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm View 2 chunks +9 lines, -9 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 1 2 4 chunks +23 lines, -21 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_expandable_item.h View 4 chunks +14 lines, -13 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_expandable_item.mm View 5 chunks +6 lines, -6 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_expandable_item_unittest.mm View 6 chunks +14 lines, -13 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_internal_cell.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_internal_cell.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_item.h View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_item.mm View 1 2 6 chunks +14 lines, -14 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_item_unittest.mm View 1 2 4 chunks +22 lines, -19 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_item.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_item.mm View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_item_actions.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_item_unittest.mm View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item.mm View 5 chunks +6 lines, -6 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item_actions.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item_unittest.mm View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
A ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm View 1 2 7 chunks +19 lines, -19 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/expandable_item.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/BUILD.gn View 1 2 1 chunk +0 lines, -58 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ios/chrome/browser/ui/suggestions/expandable_item.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_article_item.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_article_item.mm View 1 chunk +0 lines, -115 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_article_item_unittest.mm View 1 chunk +0 lines, -34 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_collection_updater.h View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_collection_updater.mm View 1 2 1 chunk +0 lines, -130 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_commands.h View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_expandable_item.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_expandable_item.mm View 1 chunk +0 lines, -237 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_expandable_item_unittest.mm View 1 chunk +0 lines, -107 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_favicon_internal_cell.h View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_favicon_internal_cell.mm View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_favicon_item.h View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_favicon_item.mm View 1 2 1 chunk +0 lines, -139 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_favicon_item_unittest.mm View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_item.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_item.mm View 1 2 1 chunk +0 lines, -97 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_item_actions.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_item_unittest.mm View 1 chunk +0 lines, -29 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_stack_item.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_stack_item.mm View 1 chunk +0 lines, -143 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_stack_item_actions.h View 1 chunk +0 lines, -16 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_stack_item_unittest.mm View 1 chunk +0 lines, -31 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_view_controller.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D ios/chrome/browser/ui/suggestions/suggestions_view_controller.mm View 1 2 1 chunk +0 lines, -164 lines 0 comments Download
M ios/chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ios/showcase/core/showcase_model.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/showcase/suggestions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/showcase/suggestions/sc_suggestions_coordinator.mm View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M ios/showcase/suggestions/sc_suggestions_egtest.mm View 1 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2643753002 Patch 180001

Messages

Total messages: 13 (7 generated)
gambard
PTAL.
3 years, 11 months ago (2017-01-20 11:48:35 UTC) #2
lpromero
lgtm https://codereview.chromium.org/2644123003/diff/1/ios/chrome/browser/ui/content_suggestions/expandable_item.h File ios/chrome/browser/ui/content_suggestions/expandable_item.h (right): https://codereview.chromium.org/2644123003/diff/1/ios/chrome/browser/ui/content_suggestions/expandable_item.h#newcode5 ios/chrome/browser/ui/content_suggestions/expandable_item.h:5: #ifndef IOS_CHROME_BROWSER_UI_SUGGESTIONS_EXPANDABLE_ITEM_H_ Update the guard. https://codereview.chromium.org/2644123003/diff/1/ios/showcase/suggestions/sc_suggestions_coordinator.mm File ios/showcase/suggestions/sc_suggestions_coordinator.mm ...
3 years, 11 months ago (2017-01-20 12:15:44 UTC) #3
marq (ping after 24h)
Move LGTM, I didn't check each file. Did you use any of the various file-moving ...
3 years, 11 months ago (2017-01-20 12:24:33 UTC) #6
gambard
Thanks! https://codereview.chromium.org/2644123003/diff/1/ios/chrome/browser/ui/content_suggestions/expandable_item.h File ios/chrome/browser/ui/content_suggestions/expandable_item.h (right): https://codereview.chromium.org/2644123003/diff/1/ios/chrome/browser/ui/content_suggestions/expandable_item.h#newcode5 ios/chrome/browser/ui/content_suggestions/expandable_item.h:5: #ifndef IOS_CHROME_BROWSER_UI_SUGGESTIONS_EXPANDABLE_ITEM_H_ On 2017/01/20 12:15:44, lpromero wrote: > ...
3 years, 11 months ago (2017-01-20 12:32:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644123003/60001
3 years, 11 months ago (2017-01-25 09:15:56 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 10:13:52 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9756a18af5acb7fcc5f674b7908d...

Powered by Google App Engine
This is Rietveld 408576698