Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 2644113002: Fix version string (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, jochen (gone - plz use gerrit)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/v8-version-string.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
vogelheim
lgtm
3 years, 11 months ago (2017-01-19 14:44:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644113002/1
3 years, 11 months ago (2017-01-19 14:45:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644113002/1
3 years, 11 months ago (2017-01-19 14:48:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/4cf44599ebada52299d15c6e45b0bdbb8eda4ce0
3 years, 11 months ago (2017-01-19 15:21:12 UTC) #13
scottmg
3 years, 11 months ago (2017-01-19 19:09:09 UTC) #14
Message was sent while issue was closed.
Doh, sorry! :( Thanks for fixing.

Powered by Google App Engine
This is Rietveld 408576698