Chromium Code Reviews
DescriptionAllow multiple calls to SetDefaultSkiaFactory on Windows.
The ppapi code currently calls SetDefaultSkiaFactory twice on Win8+.
Previous code simply leaked an SkFontMgr and the current code asserts
(which is how this was discovered). This CL allows SetDefaultSkiaFactory
to be called more than once, properly handling the reference counting
and asserting in debug builds that SetDefaultSkiaFactory is not called
after SkFontMgr::Factory is called.
BUG=chromium:682652
Review-Url: https://codereview.chromium.org/2644103003
Cr-Commit-Position: refs/heads/master@{#444865}
Committed: https://chromium.googlesource.com/chromium/src/+/5ecd69eb2b90a83d67cce615e564dcc70a2d14bb
Patch Set 1 #
Messages
Total messages: 11 (7 generated)
|
||||||||||||||||||||||||||||