Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2644103003: Allow multiple calls to SetDefaultSkiaFactory on Windows. (Closed)

Created:
3 years, 11 months ago by bungeman-chromium
Modified:
3 years, 11 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow multiple calls to SetDefaultSkiaFactory on Windows. The ppapi code currently calls SetDefaultSkiaFactory twice on Win8+. Previous code simply leaked an SkFontMgr and the current code asserts (which is how this was discovered). This CL allows SetDefaultSkiaFactory to be called more than once, properly handling the reference counting and asserting in debug builds that SetDefaultSkiaFactory is not called after SkFontMgr::Factory is called. BUG=chromium:682652 Review-Url: https://codereview.chromium.org/2644103003 Cr-Commit-Position: refs/heads/master@{#444865} Committed: https://chromium.googlesource.com/chromium/src/+/5ecd69eb2b90a83d67cce615e564dcc70a2d14bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M skia/ext/fontmgr_default_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/fontmgr_default_win.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
bungeman-chromium
3 years, 11 months ago (2017-01-19 21:04:43 UTC) #4
f(malita)
lgtm
3 years, 11 months ago (2017-01-19 21:55:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644103003/1
3 years, 11 months ago (2017-01-19 22:21:31 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 22:29:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ecd69eb2b90a83d67cce615e564...

Powered by Google App Engine
This is Rietveld 408576698