aura: Some change to how the client-lib is set up.

aura: Some change to how the client-lib is set up.

Instead of clients having to explicitly create and set up ui::Gpu,
aura::MusContextFactory instances before creating a WindowTreeClient
instance, have WindowTreeClient take care of creating and setting them
up. This allows removal of duplicate set-up code from several places.

BUG=677704
Review-Url: https://codereview.chromium.org/2644093002
Cr-Commit-Position: refs/heads/master@{#445094}
Committed: https://chromium.googlesource.com/chromium/src/+/9917dd563899eff0020ca4cad673832b620f86ec

[sadrul, 2017-01-19 12:57:42]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 12:57:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 13:09:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 13:09:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-01-19 13:13:11]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 13:13:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 13:24:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 13:24:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-01-19 15:25:08]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 15:25:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 16:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 16:25:11]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-01-19 20:06:44]

Description was changed from

==========
aura: Some change to how the client-lib is set up.

Instead of clients having to explicitly create and set up ui::Gpu,
aura::MusContextFactory instances before creating a WindowTreeClient
instance, have WindowTreeClient take care of creating and setting them
up. This allows some simplification of the API in subsequent CLs.

BUG=677704
==========

to

==========
aura: Some change to how the client-lib is set up.

Instead of clients having to explicitly create and set up ui::Gpu,
aura::MusContextFactory instances before creating a WindowTreeClient
instance, have WindowTreeClient take care of creating and setting them
up. This allows removal of duplicate set-up code from several places.

BUG=677704
==========

[sadrul, 2017-01-19 20:06:57]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2017-01-19 20:15:22]

https://codereview.chromium.org/2644093002/diff/40001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client.h (right):

https://codereview.chromium.org/2644093002/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client.h:93: scoped_refptr<base::SingleThreadTaskRunner>
io_task_runner,
An alternative is to introduce an InitializeGpu(io_task_runner), which sets up
|gpu_| and |compositor_context_factory_|. Let me know if you prefer that, over
adding this in the ctor.

[sky, 2017-01-19 21:52:58]

https://codereview.chromium.org/2644093002/diff/40001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client.h (right):

https://codereview.chromium.org/2644093002/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client.h:93: scoped_refptr<base::SingleThreadTaskRunner>
io_task_runner,
On 2017/01/19 20:15:22, sadrul wrote:
> An alternative is to introduce an InitializeGpu(io_task_runner), which sets up
> |gpu_| and |compositor_context_factory_|. Let me know if you prefer that, over
> adding this in the ctor.

I'm ok with what you have, but WDYT of moving io_task_runner to the end of the
list with a default value of null? I suggest this as it seems as though null is
used in most (all?) cases.

[sadrul, 2017-01-20 05:58:14]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 05:58:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-20 06:20:07]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 06:20:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-20 06:20:32]

https://codereview.chromium.org/2644093002/diff/40001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client.h (right):

https://codereview.chromium.org/2644093002/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client.h:93: scoped_refptr<base::SingleThreadTaskRunner>
io_task_runner,
On 2017/01/19 21:52:58, sky wrote:
> On 2017/01/19 20:15:22, sadrul wrote:
> > An alternative is to introduce an InitializeGpu(io_task_runner), which sets
up
> > |gpu_| and |compositor_context_factory_|. Let me know if you prefer that,
over
> > adding this in the ctor.
> 
> I'm ok with what you have, but WDYT of moving io_task_runner to the end of the
> list with a default value of null? I suggest this as it seems as though null
is
> used in most (all?) cases.

Makes sense. Done. (MusClient is the only place that sends the task-runner)

[commit-bot: I haz the power, 2017-01-20 08:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 08:11:23]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-20 17:14:30]

LGTM

[sadrul, 2017-01-20 18:10:32]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-01-20 18:10:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 18:15:59]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484935832574270,
"parent_rev": "fc12d84bae452abfef8e6e110908305ad5401a77", "commit_rev":
"9917dd563899eff0020ca4cad673832b620f86ec"}

[commit-bot: I haz the power, 2017-01-20 18:16:33]

Description was changed from

==========
aura: Some change to how the client-lib is set up.

Instead of clients having to explicitly create and set up ui::Gpu,
aura::MusContextFactory instances before creating a WindowTreeClient
instance, have WindowTreeClient take care of creating and setting them
up. This allows removal of duplicate set-up code from several places.

BUG=677704
==========

to

==========
aura: Some change to how the client-lib is set up.

Instead of clients having to explicitly create and set up ui::Gpu,
aura::MusContextFactory instances before creating a WindowTreeClient
instance, have WindowTreeClient take care of creating and setting them
up. This allows removal of duplicate set-up code from several places.

BUG=677704

Review-Url: https://codereview.chromium.org/2644093002
Cr-Commit-Position: refs/heads/master@{#445094}
Committed:
https://chromium.googlesource.com/chromium/src/+/9917dd563899eff0020ca4cad673...
==========

[commit-bot: I haz the power, 2017-01-20 18:16:34]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9917dd563899eff0020ca4cad673...