Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2644083005: Use a frame-specific timer task runner for ValidationMessageClientImpl. (Closed)

Created:
3 years, 11 months ago by jbroman
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a frame-specific timer task runner for ValidationMessageClientImpl. BUG=624694 Review-Url: https://codereview.chromium.org/2644083005 Cr-Commit-Position: refs/heads/master@{#444985} Committed: https://chromium.googlesource.com/chromium/src/+/14031399407b60aa7cfa33673b6aa3a2ddb46fa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M third_party/WebKit/Source/web/ValidationMessageClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
3 years, 11 months ago (2017-01-20 02:48:43 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-20 04:46:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644083005/1
3 years, 11 months ago (2017-01-20 04:49:12 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 04:53:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14031399407b60aa7cfa33673b6a...

Powered by Google App Engine
This is Rietveld 408576698