Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2644083002: Clear unhandled scheduled exceptions from ValueSelializerTest (Closed)

Created:
3 years, 11 months ago by dusan.simicic
Modified:
3 years, 11 months ago
Reviewers:
ivica.bogosavljevic, v8-mips-ports, miran.karic, Jakob Kummerow
CC:
v8-reviews_googlegroups.com, jbroman, Jakob Kummerow
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Clear unhandled scheduled exceptions from ValueSerializerTest This patch adds destructor to ValueSerializerTest test fixture class which reset unhandled scheduled exceptions thrown from the current test. In some cases unhandled scheduled exceptions from current test (eg. from one test from ValueSerializerTestWithWasm test case) produce that Context::New(isolate()) from next test's constructor returns NULL. This error is easily reproduced when unittest file (compiled for ARM or MIPS simulator) is directly executed (not by tools/run_tests.py script), so all tests are executed together. When the script is used, each test from ValueSerializerTestWithWasm test case is separately executed and unhandled exception from one test doesn't efect to another test from the same test case. BUG= Review-Url: https://codereview.chromium.org/2644083002 Cr-Commit-Position: refs/heads/master@{#42547} Committed: https://chromium.googlesource.com/v8/v8/+/73281702c8ae1fe22c2c718bc0f5dd4af66abfb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M test/unittests/value-serializer-unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
dusan.simicic
PTAL
3 years, 11 months ago (2017-01-19 11:04:09 UTC) #2
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-19 15:08:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644083002/1
3 years, 11 months ago (2017-01-20 10:13:37 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 10:49:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/73281702c8ae1fe22c2c718bc0f5dd4af66...

Powered by Google App Engine
This is Rietveld 408576698