Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2644073003:
Revert of [telemetry] Bullet proof scroll.js (Closed)
DescriptionRevert of [telemetry] Bullet proof scroll.js (patchset #4 id:60001 of https://codereview.chromium.org/2532443002/ )
Reason for revert:
CL breaks catapult->chrome autoroller see: https://github.com/catapult-project/catapult/issues/3149
Original issue's description:
> [telemetry] Bullet proof scroll.js
>
> Make scroll.js give a nice error message if the scroll point is
> off screen or if the element has zero area. Previously we just
> got a stack trace from chrome.
>
> Also fix various lint errors since this is the first time this file
> has been touched in a while.
>
> BUG=chromium:664515
>
> Review-Url: https://codereview.chromium.org/2532443002
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c3ec514d8726530643844182677304ce7f15a5c2
TBR=skyostil@chromium.org,perezju@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:664515
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2644073003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1e05d2f8401ce9b112c2f0e21269f1d7493ce88b
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
The CQ bit was checked by hjd@chromium.org
Created Revert of [telemetry] Bullet proof scroll.js
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
Description was changed from ========== Revert of [telemetry] Bullet proof scroll.js (patchset #4 id:60001 of https://codereview.chromium.org/2532443002/ ) Reason for revert: CL breaks catapult->chrome autoroller see: https://github.com/catapult-project/catapult/issues/3149 Original issue's description: > [telemetry] Bullet proof scroll.js > > Make scroll.js give a nice error message if the scroll point is > off screen or if the element has zero area. Previously we just > got a stack trace from chrome. > > Also fix various lint errors since this is the first time this file > has been touched in a while. > > BUG=chromium:664515 > > Review-Url: https://codereview.chromium.org/2532443002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... TBR=skyostil@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:664515 ========== to ========== Revert of [telemetry] Bullet proof scroll.js (patchset #4 id:60001 of https://codereview.chromium.org/2532443002/ ) Reason for revert: CL breaks catapult->chrome autoroller see: https://github.com/catapult-project/catapult/issues/3149 Original issue's description: > [telemetry] Bullet proof scroll.js > > Make scroll.js give a nice error message if the scroll point is > off screen or if the element has zero area. Previously we just > got a stack trace from chrome. > > Also fix various lint errors since this is the first time this file > has been touched in a while. > > BUG=chromium:664515 > > Review-Url: https://codereview.chromium.org/2532443002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... TBR=skyostil@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:664515 NOTRY=true ==========
The CQ bit was checked by hjd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/19 12:38:35, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...) Presubmit is failing since the previous CL fixes a bunch of lint errors in telemetry/telemetry/internal/actions/scroll.js which the revert re-breaks so I'm adding NOTRY=true to skip them.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
Description was changed from ========== Revert of [telemetry] Bullet proof scroll.js (patchset #4 id:60001 of https://codereview.chromium.org/2532443002/ ) Reason for revert: CL breaks catapult->chrome autoroller see: https://github.com/catapult-project/catapult/issues/3149 Original issue's description: > [telemetry] Bullet proof scroll.js > > Make scroll.js give a nice error message if the scroll point is > off screen or if the element has zero area. Previously we just > got a stack trace from chrome. > > Also fix various lint errors since this is the first time this file > has been touched in a while. > > BUG=chromium:664515 > > Review-Url: https://codereview.chromium.org/2532443002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... TBR=skyostil@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:664515 NOTRY=true ========== to ========== Revert of [telemetry] Bullet proof scroll.js (patchset #4 id:60001 of https://codereview.chromium.org/2532443002/ ) Reason for revert: CL breaks catapult->chrome autoroller see: https://github.com/catapult-project/catapult/issues/3149 Original issue's description: > [telemetry] Bullet proof scroll.js > > Make scroll.js give a nice error message if the scroll point is > off screen or if the element has zero area. Previously we just > got a stack trace from chrome. > > Also fix various lint errors since this is the first time this file > has been touched in a while. > > BUG=chromium:664515 > > Review-Url: https://codereview.chromium.org/2532443002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... TBR=skyostil@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:664515 NOPRESUBMIT=true NOTRY=true ==========
The CQ bit was checked by hjd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484829847296140, "parent_rev":
"c76f6de23ebfaa9817b4802085e064d0f4f4ab58", "commit_rev":
"1e05d2f8401ce9b112c2f0e21269f1d7493ce88b"}
Message was sent while issue was closed.
Description was changed from ========== Revert of [telemetry] Bullet proof scroll.js (patchset #4 id:60001 of https://codereview.chromium.org/2532443002/ ) Reason for revert: CL breaks catapult->chrome autoroller see: https://github.com/catapult-project/catapult/issues/3149 Original issue's description: > [telemetry] Bullet proof scroll.js > > Make scroll.js give a nice error message if the scroll point is > off screen or if the element has zero area. Previously we just > got a stack trace from chrome. > > Also fix various lint errors since this is the first time this file > has been touched in a while. > > BUG=chromium:664515 > > Review-Url: https://codereview.chromium.org/2532443002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... TBR=skyostil@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:664515 NOPRESUBMIT=true NOTRY=true ========== to ========== Revert of [telemetry] Bullet proof scroll.js (patchset #4 id:60001 of https://codereview.chromium.org/2532443002/ ) Reason for revert: CL breaks catapult->chrome autoroller see: https://github.com/catapult-project/catapult/issues/3149 Original issue's description: > [telemetry] Bullet proof scroll.js > > Make scroll.js give a nice error message if the scroll point is > off screen or if the element has zero area. Previously we just > got a stack trace from chrome. > > Also fix various lint errors since this is the first time this file > has been touched in a while. > > BUG=chromium:664515 > > Review-Url: https://codereview.chromium.org/2532443002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... TBR=skyostil@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:664515 NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2644073003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
