Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2644063002: Make SynchronousMutationObserver::didMergeTextNodes() to take both merged and merging nodes (Closed)

Created:
3 years, 11 months ago by yosin_UTC9
Modified:
3 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SynchronousMutationObserver::didMergeTextNodes() to take two Text nodes This patch makes |SynchronousMutationObserver::didMergeTextNodes()| to take both merge destination and merge source |Text| node for a preparation of [1] which uses both |Text| node for relocating selection. [1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized positions BUG=682878 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2644063002 Cr-Commit-Position: refs/heads/master@{#444904} Committed: https://chromium.googlesource.com/chromium/src/+/6fae5081aab1d31d63ac072293056ac5e250469a

Patch Set 1 : 2017-01-19T17:22:18 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -26 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 5 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SynchronousMutationNotifier.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SynchronousMutationNotifier.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SynchronousMutationObserver.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SynchronousMutationObserver.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
yosin_UTC9
PTAL
3 years, 11 months ago (2017-01-19 09:33:52 UTC) #6
tkent
lgtm > BUG=n/a Let's make a tracking bug for SynchronousMutationObserver.
3 years, 11 months ago (2017-01-19 23:24:50 UTC) #9
yosin_UTC9
On 2017/01/19 at 23:24:50, tkent wrote: > lgtm > > > BUG=n/a > > Let's ...
3 years, 11 months ago (2017-01-19 23:48:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644063002/1
3 years, 11 months ago (2017-01-19 23:49:50 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 00:59:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fae5081aab1d31d63ac07229305...

Powered by Google App Engine
This is Rietveld 408576698