Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issue 2644033003: [turbofan] Use new CodeAssembler::GetJSContextParameter. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use new CodeAssembler::GetJSContextParameter. This uses the aforementioned helper within the {FastAccessorAssembler}. It was made available as a helper function now that several users create code objects following {kCallJSFunction} linkage via the {CodeAssembler}. R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2644033003 Cr-Commit-Position: refs/heads/master@{#42516} Committed: https://chromium.googlesource.com/v8/v8/+/f604724448cce9994da73cf358e45be3200c07c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/fast-accessor-assembler.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Starzinger
3 years, 11 months ago (2017-01-19 15:56:24 UTC) #3
vogelheim
lgtm - Thanks!
3 years, 11 months ago (2017-01-19 16:34:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644033003/1
3 years, 11 months ago (2017-01-19 16:35:26 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 17:11:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f604724448cce9994da73cf358e45be3200...

Powered by Google App Engine
This is Rietveld 408576698