Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2644003002: Make no-compile test deterministic (Closed)

Created:
3 years, 11 months ago by wychen
Modified:
3 years, 11 months ago
Reviewers:
Nico, dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make no-compile test deterministic BUG=678903 Review-Url: https://codereview.chromium.org/2644003002 Cr-Commit-Position: refs/heads/master@{#445366} Committed: https://chromium.googlesource.com/chromium/src/+/77cbaaa8e8168b2725c4853ebffcfb8ca802e35b

Patch Set 1 #

Patch Set 2 : fix comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -32 lines) Patch
M tools/nocompile_driver.py View 1 11 chunks +34 lines, -32 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
wychen
PTAL
3 years, 11 months ago (2017-01-19 02:06:04 UTC) #2
Nico
lgtm
3 years, 11 months ago (2017-01-19 05:13:51 UTC) #3
dcheng
lgtm https://codereview.chromium.org/2644003002/diff/20001/tools/nocompile_driver.py File tools/nocompile_driver.py (right): https://codereview.chromium.org/2644003002/diff/20001/tools/nocompile_driver.py#newcode73 tools/nocompile_driver.py:73: # The GUnit test function to output for ...
3 years, 11 months ago (2017-01-19 05:36:22 UTC) #4
wychen
https://codereview.chromium.org/2644003002/diff/20001/tools/nocompile_driver.py File tools/nocompile_driver.py (right): https://codereview.chromium.org/2644003002/diff/20001/tools/nocompile_driver.py#newcode73 tools/nocompile_driver.py:73: # The GUnit test function to output for a ...
3 years, 11 months ago (2017-01-19 15:43:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644003002/20001
3 years, 11 months ago (2017-01-23 12:28:25 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 12:47:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/77cbaaa8e8168b2725c4853ebffc...

Powered by Google App Engine
This is Rietveld 408576698