Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 26440006: texdata gm: allocate gTextureData on the heap. (Closed)

Created:
7 years, 2 months ago by mtklein
Modified:
7 years, 2 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

texdata gm: allocate gTextureData on the heap. This GM is triggering a stack overflow on my laptop when I run it with dm. As I understand it, the default stack size on a Mac is 64K, but this allocates 640K. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11801

Patch Set 1 #

Patch Set 2 : more like original #

Patch Set 3 : even more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gm/texdata.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
7 years, 2 months ago (2013-10-16 11:30:00 UTC) #1
robertphillips
lgtm
7 years, 2 months ago (2013-10-16 11:38:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26440006/5001
7 years, 2 months ago (2013-10-16 11:40:37 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 11:50:52 UTC) #4
Message was sent while issue was closed.
Change committed as 11801

Powered by Google App Engine
This is Rietveld 408576698