Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2643993004: Move MediaKeySession timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MediaKeySession timer to frame-specific TaskRunnerTimer. Move MediaKeySession timer m_actionTimer to frame-specific TaskRunnerTimer. This associates it with the frame's MiscPlatformAPI timer task queue. The spec does not explicitly specify what task source it should use.[1] [1] The spec link: https://w3c.github.io/encrypted-media/#remove This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 Review-Url: https://codereview.chromium.org/2643993004 Cr-Commit-Position: refs/heads/master@{#445312} Committed: https://chromium.googlesource.com/chromium/src/+/3e95a159520fb979684df2276ab86f1da74c3704

Patch Set 1 #

Patch Set 2 : Move MediaKeySession timer to frame-specific TaskRunnerTimer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-19 19:28:57 UTC) #3
Byoungkwon Ko
PTAL
3 years, 11 months ago (2017-01-19 19:29:50 UTC) #5
haraken
They are speced tasks (https://w3c.github.io/encrypted-media/#remove) but the task source is not defined. Hence we should ...
3 years, 11 months ago (2017-01-20 04:58:08 UTC) #8
Byoungkwon Ko
As you told, I changed it to use MiscPlatformAPI. PTAL.
3 years, 11 months ago (2017-01-21 18:54:09 UTC) #14
haraken
LGTM
3 years, 11 months ago (2017-01-23 00:05:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643993004/20001
3 years, 11 months ago (2017-01-23 00:09:17 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 01:47:59 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3e95a159520fb979684df2276ab8...

Powered by Google App Engine
This is Rietveld 408576698