Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2643973002: Revert of Remove unnecessary spin in ToolTipController (Closed)

Created:
3 years, 11 months ago by chengx
Modified:
3 years, 11 months ago
Reviewers:
sky, brucedawson
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove unnecessary spin in ToolTipController (patchset #7 id:520001 of https://codereview.chromium.org/2615993002/ ) Reason for revert: Caused the regression 682141. Original issue's description: > Remove unnecessary spin in ToolTipController > > The motivation for the change is to reduce idle wakeups and therefore > reduce idle power. > > ToolTipController has a repeating 500ms timer that tries to update > itself periodically, while most of the time there is no change at all. > > This CL removes this spin but keeps the same functionality by > 1) upgrading OnMouseEvent() in TooltipController; > 2) overriding OnWindowPropertyChanged() in TooltipController; > 3) overriding OnCursorVisibilityChanged() in TooltipController. > > After the change, tooltip is updated on demand via observer pattern, > rather than unnecessary periodic checking. > > BUG=668198 > > Review-Url: https://codereview.chromium.org/2615993002 > Cr-Commit-Position: refs/heads/master@{#443584} > Committed: https://chromium.googlesource.com/chromium/src/+/6b8312a4903fc6965a64a3835524f1a8f384f26b TBR=brucedawson@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=668198 Review-Url: https://codereview.chromium.org/2643973002 Cr-Commit-Position: refs/heads/master@{#444576} Committed: https://chromium.googlesource.com/chromium/src/+/36d50e667f1639241bb8a0798086c764e350047e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -68 lines) Patch
M ash/tooltips/tooltip_controller_unittest.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M ui/views/corewm/tooltip_controller.h View 4 chunks +6 lines, -12 lines 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 8 chunks +40 lines, -22 lines 0 comments Download
M ui/views/corewm/tooltip_controller_test_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller_test_helper.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 25 chunks +54 lines, -13 lines 0 comments Download
M ui/wm/public/tooltip_client.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/wm/public/tooltip_client.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
chengx
Created Revert of Remove unnecessary spin in ToolTipController
3 years, 11 months ago (2017-01-18 22:50:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643973002/1
3 years, 11 months ago (2017-01-18 22:51:22 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-18 22:51:24 UTC) #5
chengx
Hi, the previous tooltip fix caused regression issue 682141. Though the fix should be small, ...
3 years, 11 months ago (2017-01-18 23:16:39 UTC) #6
sky
LGTM
3 years, 11 months ago (2017-01-18 23:38:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643973002/1
3 years, 11 months ago (2017-01-18 23:47:12 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 00:55:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36d50e667f1639241bb8a0798086...

Powered by Google App Engine
This is Rietveld 408576698