Chromium Code Reviews
DescriptionRevert of Remove unnecessary spin in ToolTipController (patchset #7 id:520001 of https://codereview.chromium.org/2615993002/ )
Reason for revert:
Caused the regression 682141.
Original issue's description:
> Remove unnecessary spin in ToolTipController
>
> The motivation for the change is to reduce idle wakeups and therefore
> reduce idle power.
>
> ToolTipController has a repeating 500ms timer that tries to update
> itself periodically, while most of the time there is no change at all.
>
> This CL removes this spin but keeps the same functionality by
> 1) upgrading OnMouseEvent() in TooltipController;
> 2) overriding OnWindowPropertyChanged() in TooltipController;
> 3) overriding OnCursorVisibilityChanged() in TooltipController.
>
> After the change, tooltip is updated on demand via observer pattern,
> rather than unnecessary periodic checking.
>
> BUG=668198
>
> Review-Url: https://codereview.chromium.org/2615993002
> Cr-Commit-Position: refs/heads/master@{#443584}
> Committed: https://chromium.googlesource.com/chromium/src/+/6b8312a4903fc6965a64a3835524f1a8f384f26b
TBR=brucedawson@chromium.org,sky@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=668198
Review-Url: https://codereview.chromium.org/2643973002
Cr-Commit-Position: refs/heads/master@{#444576}
Committed: https://chromium.googlesource.com/chromium/src/+/36d50e667f1639241bb8a0798086c764e350047e
Patch Set 1 #
Messages
Total messages: 12 (5 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||