Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2643923004: [Gin] Change the Ignition experiment to test Ignition+TurboFan. (Closed)

Created:
3 years, 11 months ago by rmcilroy
Modified:
3 years, 11 months ago
CC:
asvitkine+watch_chromium.org, Benedikt Meurer, chromium-reviews, hablich1, mvstanton
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Gin] Change the Ignition experiment to test Ignition+TurboFan. Changes the current V8 Ignition Experiment to instead test Ignition and Turbofan, the future compiler configuration of V8. BUG=v8:5870 Review-Url: https://codereview.chromium.org/2643923004 Cr-Commit-Position: refs/heads/master@{#444881} Committed: https://chromium.googlesource.com/chromium/src/+/d60ed5a0b89e9604c2c5f42d92f8be835e7b71e3

Patch Set 1 #

Patch Set 2 : Add histogram changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gin/gin_features.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M gin/public/gin_features.h View 1 chunk +1 line, -1 line 0 comments Download
M gin/v8_initializer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
rmcilroy
Jochen, PTAL, thanks.
3 years, 11 months ago (2017-01-19 16:36:22 UTC) #3
rmcilroy
hablich@, mvstanton@, bmeurer@ FYI.
3 years, 11 months ago (2017-01-19 16:37:58 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-19 17:28:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643923004/20001
3 years, 11 months ago (2017-01-19 17:57:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/349660)
3 years, 11 months ago (2017-01-19 18:43:38 UTC) #9
Michael Hablich
On 2017/01/19 18:43:38, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 11 months ago (2017-01-19 18:46:04 UTC) #10
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-19 18:51:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643923004/40001
3 years, 11 months ago (2017-01-19 23:06:15 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 23:17:53 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d60ed5a0b89e9604c2c5f42d92f8...

Powered by Google App Engine
This is Rietveld 408576698