Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

WebAPKs can be disabled via:
- chrome://flags
- variations

When a user tries to launch a WebAPK (that the user installed while WebAPKs
were enabled) when WebAPKs are disabled, this CL makes the WebAPK launch in a
regular browser tab. Previously nothing would occur when the user taps on the
homescreen shortcut.

BUG=682524
Review-Url: https://codereview.chromium.org/2643853004
Cr-Commit-Position: refs/heads/master@{#444622}
Committed: https://chromium.googlesource.com/chromium/src/+/e7c168f910ca1d4b565f16abe25e6fdf0352f7a3

[pkotwicz, 2017-01-19 02:05:21]

Description was changed from

==========
Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

WebAPKs can be disabled via:
- chrome://flags
- variations

When a user tries to launch a WebAPK when WebAPKs are disabled, this CL makes
the WebAPK launch in a regular browser tab. Previously nothing would occur when
the user taps on the homescreen shortcut.

BUG=webappUrl
==========

to

==========
Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

WebAPKs can be disabled via:
- chrome://flags
- variations

When a user tries to launch a WebAPK when WebAPKs are disabled, this CL makes
the WebAPK launch in a regular browser tab. Previously nothing would occur when
the user taps on the homescreen shortcut.

BUG=webappUrl
==========

[pkotwicz, 2017-01-19 02:05:55]

Description was changed from

==========
Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

WebAPKs can be disabled via:
- chrome://flags
- variations

When a user tries to launch a WebAPK when WebAPKs are disabled, this CL makes
the WebAPK launch in a regular browser tab. Previously nothing would occur when
the user taps on the homescreen shortcut.

BUG=webappUrl
==========

to

==========
Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

WebAPKs can be disabled via:
- chrome://flags
- variations

When a user tries to launch a WebAPK (that the user installed while WebAPKs
were enabled) when WebAPKs are disabled, this CL makes the WebAPK launch in a
regular browser tab. Previously nothing would occur when the user taps on the
homescreen shortcut.

BUG=webappUrl
==========

[pkotwicz, 2017-01-19 02:06:36]

Description was changed from

==========
Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

WebAPKs can be disabled via:
- chrome://flags
- variations

When a user tries to launch a WebAPK (that the user installed while WebAPKs
were enabled) when WebAPKs are disabled, this CL makes the WebAPK launch in a
regular browser tab. Previously nothing would occur when the user taps on the
homescreen shortcut.

BUG=webappUrl
==========

to

==========
Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

WebAPKs can be disabled via:
- chrome://flags
- variations

When a user tries to launch a WebAPK (that the user installed while WebAPKs
were enabled) when WebAPKs are disabled, this CL makes the WebAPK launch in a
regular browser tab. Previously nothing would occur when the user taps on the
homescreen shortcut.

BUG=682524
==========

[pkotwicz, 2017-01-19 02:06:55]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-01-19 02:06:56]

Dominick, can you please take a look?

[dominickn, 2017-01-19 02:11:15]

If we're still able to pull a URL out of the intent, does it have any other data
in it? Would it be possible to fall back to regular webapp mode here?

[dominickn, 2017-01-19 02:11:29]

Forgot to publish drafts

https://codereview.chromium.org/2643853004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
(right):

https://codereview.chromium.org/2643853004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java:66:
String url = IntentUtils.safeGetStringExtra(intent, ShortcutHelper.EXTRA_URL);
We should at least verify that the url isn't empty before launching in a tab.

https://codereview.chromium.org/2643853004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java:94:
private void launchRegularBrowser(String webappUrl, int webappSource) {
Nit: call this method launchInTab

[pkotwicz, 2017-01-19 02:32:41]

Dominick, can you please take another look?

It might be possible to launch a WebAPK as a webapp when WebAPKs are disabled
but it is not straightforward.

WebAPKs don't have a mac. I guess we could bypass the mac check if the WebAPK is
valid but WebAPKs are disabled. I am not sure what else we would need to do

[dominickn, 2017-01-19 02:42:39]

lgtm

If we have to disable WebAPKs, it's a huge downgrade to have PWAs open in the
browser tab. If there's any chance at all that we'd have to turn off WebAPKs or
something like that, I think it's worth investigating storing exactly the same
information for a WebAPK as we do for regular web apps (such as the MAC), so
that it's a perfect fallback.

[pkotwicz, 2017-01-19 02:51:51]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-01-19 02:52:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkotwicz, 2017-01-19 02:53:39]

Its not possible to store a mac for WebAPKs because the Mac is a random number
and the server wants to be able to vend the same WebAPK to multiple clients.
Perhaps we can launch WebAPKs in webapp mode even if they don't have a Mac

[pkotwicz, 2017-01-19 02:54:38]

Dominick, what do you think?

[dominickn, 2017-01-19 03:09:33]

On 2017/01/19 02:54:38, pkotwicz wrote:
> Dominick, what do you think?

Hmm, the purpose of the MAC is to make sure that the incoming intent was
generated by Chrome. All we have in WebappLauncherActivity is an intent - is
there any way to securely verify that it came from a WebAPK? I'm not sure if
that's possible.

When a WebAPK is vended and sent to Chrome, is there any way that Chrome could
inject the MAC? I'm sorry I'm not a big expert on that phase :)

[commit-bot: I haz the power, 2017-01-19 03:26:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484794311760610,
"parent_rev": "c083c885f19967daef65cce687ab0b0d695adf69", "commit_rev":
"e7c168f910ca1d4b565f16abe25e6fdf0352f7a3"}

[commit-bot: I haz the power, 2017-01-19 03:26:59]

Description was changed from

==========
Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

WebAPKs can be disabled via:
- chrome://flags
- variations

When a user tries to launch a WebAPK (that the user installed while WebAPKs
were enabled) when WebAPKs are disabled, this CL makes the WebAPK launch in a
regular browser tab. Previously nothing would occur when the user taps on the
homescreen shortcut.

BUG=682524
==========

to

==========
Launch WebAPK in regular browser if user disables WebAPKs in chrome://flags

WebAPKs can be disabled via:
- chrome://flags
- variations

When a user tries to launch a WebAPK (that the user installed while WebAPKs
were enabled) when WebAPKs are disabled, this CL makes the WebAPK launch in a
regular browser tab. Previously nothing would occur when the user taps on the
homescreen shortcut.

BUG=682524

Review-Url: https://codereview.chromium.org/2643853004
Cr-Commit-Position: refs/heads/master@{#444622}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7c168f910ca1d4b565f16abe25e...
==========

[commit-bot: I haz the power, 2017-01-19 03:27:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e7c168f910ca1d4b565f16abe25e...