Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2643813003: WebAPKs: Handle WebAPK WebappRegistry info and WebAPKs being disabled in ServiceTabLauncher (Closed)

Created:
3 years, 11 months ago by pkotwicz
Modified:
3 years, 11 months ago
Reviewers:
dominickn, gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebAPKs: Handle WebAPK WebappRegistry info and WebAPKs being disabled in ServiceTabLauncher WebAPKs can be disabled - by the user via chrome://flags - via Chrome variations This CL handles a user having a WebAPK installed but WebAPKs being disabled in ServiceTabLauncher. Currently, if the URL corresponds to a WebAPK, we attempt to launch the WebAPK in webapp mode because there is a listing in WebappDataStorage. This CL opens a regular browser tab if the URL corresponds to a WebAPK when WebAPKs are disabled. BUG=682540 Review-Url: https://codereview.chromium.org/2643813003 Cr-Commit-Position: refs/heads/master@{#444793} Committed: https://chromium.googlesource.com/chromium/src/+/f5a2aee10eb115bb0e2d04b8343ce60b7b6936fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
pkotwicz
Dominick, can you please take a look?
3 years, 11 months ago (2017-01-19 05:00:51 UTC) #2
dominickn
lgtm
3 years, 11 months ago (2017-01-19 05:16:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643813003/1
3 years, 11 months ago (2017-01-19 05:57:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/345093)
3 years, 11 months ago (2017-01-19 06:04:50 UTC) #7
pkotwicz
dfalcantara@ for ServiceTabLauncher
3 years, 11 months ago (2017-01-19 16:06:22 UTC) #9
gone
owners lgtm
3 years, 11 months ago (2017-01-19 18:03:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643813003/1
3 years, 11 months ago (2017-01-19 18:26:16 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 18:30:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5a2aee10eb115bb0e2d04b8343c...

Powered by Google App Engine
This is Rietveld 408576698