Issue 2643793002: Fixes to status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2643793002: Fixes to status (Closed)

Created:
3 years, 11 months ago by vsm

Modified:
3 years, 11 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixes to status TBR=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/21e1ebc3aa61cf9b90fd986071a487ad7b8d402e

Patch Set 1 #

Total comments: 2

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	pkg/dev_compiler/test/browser/language_tests.js	View		3 chunks	+6 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

Committed patchset #1 (id:1) manually as 21e1ebc3aa61cf9b90fd986071a487ad7b8d402e (presubmit successful).

3 years, 11 months ago (2017-01-18 14:17:05 UTC) #2

vsm

https://codereview.chromium.org/2643793002/diff/1/pkg/dev_compiler/test/browser/language_tests.js File pkg/dev_compiler/test/browser/language_tests.js (right): https://codereview.chromium.org/2643793002/diff/1/pkg/dev_compiler/test/browser/language_tests.js#newcode208 pkg/dev_compiler/test/browser/language_tests.js:208: 'memory_swap_test': is.firefox() ? skip_timeout : pass, Apparently, there was ...

3 years, 11 months ago (2017-01-18 16:01:18 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages