Chromium Code Reviews| Index: pkg/dev_compiler/test/browser/language_tests.js |
| diff --git a/pkg/dev_compiler/test/browser/language_tests.js b/pkg/dev_compiler/test/browser/language_tests.js |
| index 89f90d33c6510c327207f09085eb367faffb9e63..910b2914aa6dbacca6ea067eacf5283a837cfd56 100644 |
| --- a/pkg/dev_compiler/test/browser/language_tests.js |
| +++ b/pkg/dev_compiler/test/browser/language_tests.js |
| @@ -32,6 +32,10 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'], |
| const firefox_fail = is.firefox() ? fail : pass; |
| const chrome_fail = is.chrome() ? fail : pass; |
| + // These are typically tests with asynchronous exceptions that our |
| + // test framework doesn't always catch. |
| + const flaky = 'skip'; |
| + |
| // Tests marked with this are still using the deprecated unittest package |
| // because they rely on its support for futures and asynchronous tests, which |
| // expect and minitest do not handle. |
| @@ -201,7 +205,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'], |
| 'many_generic_instanceof_test': fail, |
| 'map_literal10_test': fail, |
| 'map_literal7_test': fail, |
| - 'memory_swap_test': is.firefox() ? skip_timeout : pass, |
| + 'memory_swap_test': is.firefox() ? skip_timeout : pass, |
|
vsm
2017/01/18 16:01:18
Apparently, there was some weird char in the origi
|
| 'method_invocation_test': fail, |
| 'mint_arithmetic_test': fail, |
| 'mixin_forwarding_constructor3_test': fail, |
| @@ -229,7 +233,7 @@ define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'], |
| 'regress_16640_test': fail, |
| 'regress_18535_test': fail, |
| 'regress_22666_test': fail, |
| - 'regress_22777_test': is.firefox() ? 'skip' : fail, // flake on ff |
| + 'regress_22777_test': flaky, |
|
vsm
2017/01/18 16:01:17
Flaking on Chrome as well. We're not handling the
|
| 'setter_no_getter_test_01_multi': fail, |
| 'stack_overflow_stacktrace_test': fail, |
| 'stack_overflow_test': fail, |