Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2643783002: [wasm] check that there is at most 1 table (Closed)

Created:
3 years, 11 months ago by rossberg
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] check that there is at most 1 table R=titzer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2643783002 Cr-Commit-Position: refs/heads/master@{#42465} Committed: https://chromium.googlesource.com/v8/v8/+/d62914f6e9819a9def5068f8afea2ca8c01f52d3

Patch Set 1 #

Patch Set 2 : Tweak module builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M src/wasm/module-decoder.cc View 5 chunks +19 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/indirect-tables.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
rossberg
3 years, 11 months ago (2017-01-18 14:09:38 UTC) #1
titzer
lgtm
3 years, 11 months ago (2017-01-18 14:26:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643783002/1
3 years, 11 months ago (2017-01-18 14:37:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/15720) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 11 months ago (2017-01-18 14:52:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643783002/20001
3 years, 11 months ago (2017-01-18 15:10:09 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 15:36:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d62914f6e9819a9def5068f8afea2ca8c01...

Powered by Google App Engine
This is Rietveld 408576698