Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2643773008: [turbofan] Remove --turbo-loop-stackcheck flag. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove --turbo-loop-stackcheck flag. The flag in question was on by defautl for a while now and has never been supported for optimized code generated from bytecode. We no longer support eliding stack-checks within loops just in optimized code. R=bmeurer@chromium.org BUG=v8:5653 Review-Url: https://codereview.chromium.org/2643773008 Cr-Commit-Position: refs/heads/master@{#42574} Committed: https://chromium.googlesource.com/v8/v8/+/a5b89e21461789a1304c935844005f8ce284fa6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Starzinger
3 years, 11 months ago (2017-01-20 13:25:27 UTC) #3
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-20 18:05:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643773008/1
3 years, 11 months ago (2017-01-20 18:05:07 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 18:45:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a5b89e21461789a1304c935844005f8ce28...

Powered by Google App Engine
This is Rietveld 408576698