Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2643773007: Remove internals.address(node) (Closed)

Created:
3 years, 11 months ago by esprehn
Modified:
3 years, 10 months ago
Reviewers:
dglazkov, ojan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove internals.address(node) BUG=682982 Review-Url: https://codereview.chromium.org/2643773007 Cr-Commit-Position: refs/heads/master@{#446881} Committed: https://chromium.googlesource.com/chromium/src/+/b34b8896fe3b95563ea13eab767b102a120d464e

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/resources/dump-as-markup.js View 4 chunks +10 lines, -11 lines 3 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
esprehn
3 years, 11 months ago (2017-01-20 05:19:24 UTC) #4
dglazkov
lgtm https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTests/resources/dump-as-markup.js File third_party/WebKit/LayoutTests/resources/dump-as-markup.js (right): https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTests/resources/dump-as-markup.js#newcode225 third_party/WebKit/LayoutTests/resources/dump-as-markup.js:225: // TODO(esprehn): This should definitely be ==. Could ...
3 years, 11 months ago (2017-01-20 16:37:26 UTC) #7
esprehn
https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTests/resources/dump-as-markup.js File third_party/WebKit/LayoutTests/resources/dump-as-markup.js (right): https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTests/resources/dump-as-markup.js#newcode225 third_party/WebKit/LayoutTests/resources/dump-as-markup.js:225: // TODO(esprehn): This should definitely be ==. On 2017/01/20 ...
3 years, 11 months ago (2017-01-20 17:51:50 UTC) #8
dglazkov
https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTests/resources/dump-as-markup.js File third_party/WebKit/LayoutTests/resources/dump-as-markup.js (right): https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTests/resources/dump-as-markup.js#newcode225 third_party/WebKit/LayoutTests/resources/dump-as-markup.js:225: // TODO(esprehn): This should definitely be ==. On 2017/01/20 ...
3 years, 11 months ago (2017-01-23 04:29:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643773007/1
3 years, 10 months ago (2017-01-28 00:08:09 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 02:07:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b34b8896fe3b95563ea13eab767b...

Powered by Google App Engine
This is Rietveld 408576698