Remove internals.address(node)

Remove internals.address(node)

BUG=682982
Review-Url: https://codereview.chromium.org/2643773007
Cr-Commit-Position: refs/heads/master@{#446881}
Committed: https://chromium.googlesource.com/chromium/src/+/b34b8896fe3b95563ea13eab767b102a120d464e

[esprehn, 2017-01-20 04:49:57]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 04:50:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2017-01-20 05:19:24]

esprehn@chromium.org changed reviewers:
+ dglazkov@chromium.org, ojan@chromium.org

[commit-bot: I haz the power, 2017-01-20 06:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 06:10:56]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2017-01-20 16:37:26]

lgtm

https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/resources/dump-as-markup.js (right):

https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/resources/dump-as-markup.js:225: //
TODO(esprehn): This should definitely be ==.
Could you expand on this comment? What does it mean?

[esprehn, 2017-01-20 17:51:50]

https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/resources/dump-as-markup.js (right):

https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/resources/dump-as-markup.js:225: //
TODO(esprehn): This should definitely be ==.
On 2017/01/20 at 16:37:26, dglazkov wrote:
> Could you expand on this comment? What does it mean?

It's using single equal instead of double equal. So it's actually assigning to
the read only namespaceURI field which makes this always true.

[dglazkov, 2017-01-23 04:29:36]

https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/resources/dump-as-markup.js (right):

https://codereview.chromium.org/2643773007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/resources/dump-as-markup.js:225: //
TODO(esprehn): This should definitely be ==.
On 2017/01/20 at 17:51:50, esprehn wrote:
> On 2017/01/20 at 16:37:26, dglazkov wrote:
> > Could you expand on this comment? What does it mean?
> 
> It's using single equal instead of double equal. So it's actually assigning to
the read only namespaceURI field which makes this always true.

Oh, I missed it. I was looking at the node.tagName condition.  Yup.

[esprehn, 2017-01-28 00:07:36]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2017-01-28 00:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 02:05:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485562056783530, "parent_rev":
"7f89cc52e9299192015ccaf375f15e72d5da2dd1", "commit_rev":
"b34b8896fe3b95563ea13eab767b102a120d464e"}

[commit-bot: I haz the power, 2017-01-28 02:07:02]

Description was changed from

==========
Remove internals.address(node)

BUG=682982
==========

to

==========
Remove internals.address(node)

BUG=682982

Review-Url: https://codereview.chromium.org/2643773007
Cr-Commit-Position: refs/heads/master@{#446881}
Committed:
https://chromium.googlesource.com/chromium/src/+/b34b8896fe3b95563ea13eab767b...
==========

[commit-bot: I haz the power, 2017-01-28 02:07:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b34b8896fe3b95563ea13eab767b...